From e8556f1d56b38abac103c3c7dbfc55f4c0c44ebc Mon Sep 17 00:00:00 2001 From: laurentiu021 Date: Fri, 12 Jun 2026 16:52:00 +0300 Subject: [PATCH] refactor: use collection expressions and is-null pattern in remaining sites --- SysManager/SysManager.Tests/EventLogServiceTests.cs | 2 +- SysManager/SysManager/Helpers/EqualityConverter.cs | 2 +- SysManager/SysManager/Models/TargetPreset.cs | 6 +++--- SysManager/SysManager/Services/AppAlertService.cs | 6 +++--- SysManager/SysManager/Services/DeepCleanupService.cs | 6 +++--- SysManager/SysManager/Services/DuplicateFileService.cs | 2 +- SysManager/SysManager/Services/FileShredderService.cs | 2 +- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/SysManager/SysManager.Tests/EventLogServiceTests.cs b/SysManager/SysManager.Tests/EventLogServiceTests.cs index e74a998..751b4c6 100644 --- a/SysManager/SysManager.Tests/EventLogServiceTests.cs +++ b/SysManager/SysManager.Tests/EventLogServiceTests.cs @@ -34,7 +34,7 @@ public void BuildXPath_WithSeverity_IncludesLevel() { var opt = new EventLogQueryOptions { - Severities = new List { EventSeverity.Error } + Severities = [EventSeverity.Error] }; var result = InvokeBuildXPath(opt); Assert.Contains("Level=2", result); diff --git a/SysManager/SysManager/Helpers/EqualityConverter.cs b/SysManager/SysManager/Helpers/EqualityConverter.cs index fb2f6f7..3088a33 100644 --- a/SysManager/SysManager/Helpers/EqualityConverter.cs +++ b/SysManager/SysManager/Helpers/EqualityConverter.cs @@ -17,7 +17,7 @@ public sealed class EqualityConverter : IValueConverter { public object Convert(object? value, Type targetType, object? parameter, CultureInfo culture) { - if (value == null || parameter == null) + if (value is null || parameter is null) return false; return string.Equals(value.ToString(), parameter.ToString(), StringComparison.Ordinal); } diff --git a/SysManager/SysManager/Models/TargetPreset.cs b/SysManager/SysManager/Models/TargetPreset.cs index 01db7d1..a8783c3 100644 --- a/SysManager/SysManager/Models/TargetPreset.cs +++ b/SysManager/SysManager/Models/TargetPreset.cs @@ -74,8 +74,8 @@ public static class TargetPresets ("FACEIT UK", "82.145.38.1"), }); - public static readonly IReadOnlyList All = new[] - { + public static readonly IReadOnlyList All = + [ Global, CS2Europe, FaceitEurope, PubgEurope, Streaming - }; + ]; } diff --git a/SysManager/SysManager/Services/AppAlertService.cs b/SysManager/SysManager/Services/AppAlertService.cs index e4a9feb..a71604c 100644 --- a/SysManager/SysManager/Services/AppAlertService.cs +++ b/SysManager/SysManager/Services/AppAlertService.cs @@ -116,11 +116,11 @@ public void Stop() public static IReadOnlyList GetRegistryApps() { List apps = []; - var paths = new[] - { + string[] paths = + [ @"SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall", @"SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall" - }; + ]; foreach (var path in paths) { diff --git a/SysManager/SysManager/Services/DeepCleanupService.cs b/SysManager/SysManager/Services/DeepCleanupService.cs index 6bc9d3f..63a0656 100644 --- a/SysManager/SysManager/Services/DeepCleanupService.cs +++ b/SysManager/SysManager/Services/DeepCleanupService.cs @@ -253,11 +253,11 @@ private static IReadOnlyList Scan(IProgress? prog private static string[] SteamRoots(string pfx86, string pf) { - var roots = new List - { + List roots = + [ Path.Combine(pfx86, "Steam"), Path.Combine(pf, "Steam"), - }; + ]; foreach (var drive in DriveInfo.GetDrives().Where(d => d.DriveType == DriveType.Fixed && d.IsReady)) { var candidate = Path.Combine(drive.RootDirectory.FullName, "Steam"); diff --git a/SysManager/SysManager/Services/DuplicateFileService.cs b/SysManager/SysManager/Services/DuplicateFileService.cs index 016126f..8d1d542 100644 --- a/SysManager/SysManager/Services/DuplicateFileService.cs +++ b/SysManager/SysManager/Services/DuplicateFileService.cs @@ -59,7 +59,7 @@ private static IReadOnlyList Scan( return []; // ── Pass 1: discover files and group by size ── - var sizeGroups = new Dictionary>(); + Dictionary> sizeGroups = []; long discovered = 0; var stack = new Stack(); stack.Push(rootPath); diff --git a/SysManager/SysManager/Services/FileShredderService.cs b/SysManager/SysManager/Services/FileShredderService.cs index 2dc4ef6..421175c 100644 --- a/SysManager/SysManager/Services/FileShredderService.cs +++ b/SysManager/SysManager/Services/FileShredderService.cs @@ -195,7 +195,7 @@ public async Task ShredFolderAsync(string folderPath, ShredMethod method, IProgr private static List EnumerateFilesSafe(string rootPath) { List results = []; - var stack = new Stack(); + Stack stack = []; stack.Push(new DirectoryInfo(rootPath)); while (stack.Count > 0)