one more correction in the definition of starting values for the Hill model

mldelignette · mldelignette · commit 37895715e785 · 2025-07-30T17:20:02.000+02:00
diff --git a/NEWS.md b/NEWS.md
@@ -1,10 +1,10 @@
 # DRomics (development version)
 
 NEW FEATURES
+- Correction of the definition of starting values of the parameter e of the Gaussprobit model and of the Hill model. This could help the fit of those models in few cases.
 
 BUG FIXES
 
-- Fix a bug in the definition of starting values of the parameter e of the Gaussprobit model. This could help the fit in few cases.
 
 # DRomics 2.6-2
 
diff --git a/R/util-basicandfitfunc.R b/R/util-basicandfitfunc.R
@@ -117,7 +117,7 @@ startvalHillnls2 <- function(x, y, xm, ym, increase) { # requires the definition
   xreg <- log(x[x != 0])
   reg <- stats::lm(yreg ~ xreg)
   b <- reg$coefficients[2]
-  e <- reg$coefficients[1] / (-b)
+  e <- exp(reg$coefficients[1] / (-b))
   startval <- list(b = b, c = c, d = d, e = e)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ startvalHillnls2 <- function(x, y, xm, ym, increase) { # requires the definition`
`117`	`117`	`xreg <- log(x[x != 0])`
`118`	`118`	`reg <- stats::lm(yreg ~ xreg)`
`119`	`119`	`b <- reg$coefficients[2]`
`120`		`- e <- reg$coefficients[1] / (-b)`
	`120`	`+ e <- exp(reg$coefficients[1] / (-b))`
`121`	`121`	`startval <- list(b = b, c = c, d = d, e = e)`
`122`	`122`	`}`
`123`	`123`