clippy

Author: TomWambsgans

crates/backend/koala-bear/src/benchmark_poseidons.rs

@@ -21,8 +21,8 @@ fn bench_poseidon() {
     let poseidon1_24 = default_koalabear_poseidon1_24();
 
     // warming
-    let mut state_16: [crate::PackedMontyField31Neon<crate::KoalaBearParameters>; 16] = [FPacking::ZERO; 16];
-    let mut state_24: [crate::PackedMontyField31Neon<crate::KoalaBearParameters>; 24] = [FPacking::ZERO; 24];
+    let mut state_16: [FPacking; 16] = [FPacking::ZERO; 16];
+    let mut state_24: [FPacking; 24] = [FPacking::ZERO; 24];
     for _ in 0..1 << 15 {
         poseidon1_16.compress_in_place(&mut state_16);
         poseidon1_24.compress_in_place(&mut state_24);

crates/backend/koala-bear/src/poseidon1_koalabear_16.rs

@@ -25,25 +25,34 @@ const MDS_CIRC_COL: [KoalaBear; 16] = KoalaBear::new_array([1, 3, 13, 22, 67, 2,
 // Forward twiddles for 16-point FFT: W_k = omega^k
 // =========================================================================
 
+#[cfg(all(target_arch = "aarch64", target_feature = "neon"))]
 const W1: KoalaBear = KoalaBear::new(0x08dbd69c);
+#[cfg(all(target_arch = "aarch64", target_feature = "neon"))]
 const W2: KoalaBear = KoalaBear::new(0x6832fe4a);
+#[cfg(all(target_arch = "aarch64", target_feature = "neon"))]
 const W3: KoalaBear = KoalaBear::new(0x27ae21e2);
+#[cfg(all(target_arch = "aarch64", target_feature = "neon"))]
 const W4: KoalaBear = KoalaBear::new(0x7e010002);
+#[cfg(all(target_arch = "aarch64", target_feature = "neon"))]
 const W5: KoalaBear = KoalaBear::new(0x3a89a025);
+#[cfg(all(target_arch = "aarch64", target_feature = "neon"))]
 const W6: KoalaBear = KoalaBear::new(0x174e3650);
+#[cfg(all(target_arch = "aarch64", target_feature = "neon"))]
 const W7: KoalaBear = KoalaBear::new(0x27dfce22);
 
 // =========================================================================
 // 16-point FFT / IFFT (radix-2, fully unrolled, in-place)
 // =========================================================================
 
+#[cfg(all(target_arch = "aarch64", target_feature = "neon"))]
 #[inline(always)]
 fn bt<R: Algebra<KoalaBear>>(v: &mut [R; 16], lo: usize, hi: usize) {
     let (a, b) = (v[lo], v[hi]);
     v[lo] = a + b;
     v[hi] = a - b;
 }
 
+#[cfg(all(target_arch = "aarch64", target_feature = "neon"))]
 #[inline(always)]
 fn dit<R: Algebra<KoalaBear>>(v: &mut [R; 16], lo: usize, hi: usize, t: KoalaBear) {
     let a = v[lo];
@@ -52,13 +61,15 @@ fn dit<R: Algebra<KoalaBear>>(v: &mut [R; 16], lo: usize, hi: usize, t: KoalaBea
     v[hi] = a - tb;
 }
 
+#[cfg(all(target_arch = "aarch64", target_feature = "neon"))]
 #[inline(always)]
 fn neg_dif<R: Algebra<KoalaBear>>(v: &mut [R; 16], lo: usize, hi: usize, t: KoalaBear) {
     let (a, b) = (v[lo], v[hi]);
     v[lo] = a + b;
     v[hi] = (b - a) * t;
 }
 
+#[cfg(all(target_arch = "aarch64", target_feature = "neon"))]
 #[inline(always)]
 #[cfg(all(target_arch = "aarch64", target_feature = "neon"))]
 fn dif_ifft_16_mut<R: Algebra<KoalaBear>>(f: &mut [R; 16]) {
@@ -96,6 +107,7 @@ fn dif_ifft_16_mut<R: Algebra<KoalaBear>>(f: &mut [R; 16]) {
     bt(f, 14, 15);
 }
 
+#[cfg(all(target_arch = "aarch64", target_feature = "neon"))]
 #[inline(always)]
 #[cfg(all(target_arch = "aarch64", target_feature = "neon"))]
 fn dit_fft_16_mut<R: Algebra<KoalaBear>>(f: &mut [R; 16]) {

crates/backend/koala-bear/src/quintic_extension/packed_extension.rs

@@ -16,6 +16,7 @@ use serde::{Deserialize, Serialize};
 use utils::{flatten_to_base, reconstitute_from_base};
 
 use super::extension::QuinticExtensionField;
+#[allow(unused_imports)]
 use crate::{KoalaBear, QuinticExtendable};
 
 #[derive(Copy, Clone, Eq, PartialEq, Hash, Debug, Serialize, Deserialize, PartialOrd, Ord)]
@@ -78,6 +79,7 @@ impl<F: QuinticExtendable, PF: PackedField<Scalar = F>> Algebra<QuinticExtension
 
 impl<F: QuinticExtendable, PF: PackedField<Scalar = F>> Algebra<PF> for PackedQuinticExtensionField<F, PF> {}
 
+#[allow(unused_macros)]
 macro_rules! impl_packed_ext_scalar_ops {
     ($pf:ty) => {
         impl Add<KoalaBear> for PackedQuinticExtensionField<KoalaBear, $pf> {

crates/lean_vm/src/isa/hint.rs

@@ -170,6 +170,7 @@ impl CustomHint {
                 let chunk_size = args[3].read_value(ctx.memory, ctx.fp)?.to_usize();
                 assert!(24_usize.is_multiple_of(chunk_size));
                 let mut memory_index_decomposed = decomposed_ptr;
+                #[allow(clippy::explicit_counter_loop)]
                 for i in 0..24 / chunk_size {
                     let value = F::from_usize((value >> (chunk_size * i)) & ((1 << chunk_size) - 1));
                     ctx.memory.set(memory_index_decomposed, value)?;

crates/leansig_wrapper/src/lib.rs

@@ -1,4 +1,3 @@
-use std::array;
 use backend::{KoalaBear, integers::QuotientMap};
 use leansig::{
     inc_encoding::target_sum::TargetSumEncoding,
@@ -17,6 +16,7 @@ use leansig::{
 };
 use leansig_fast_keygen::signature::SignatureScheme as FastKeyGenSignatureScheme;
 use p3_field::PrimeField32;
+use std::array;
 
 #[cfg(feature = "test-config")]
 pub const V: usize = 4;