Split contracts generator tests classes into separate, not partial, classes

jakubfijalkowski · jakubfijalkowski · commit 4e19bc445c1d · 2021-01-11T13:46:33.000+01:00
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/Dart/ContractsGeneratorTestHelpers.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/Dart/ContractsGeneratorTestHelpers.cs
@@ -32,7 +32,7 @@ namespace {namespaceName}
             ");
         }
 
-        public static readonly GeneratorConfiguration DefaultDartConfiguration = new GeneratorConfiguration()
+        public static readonly GeneratorConfiguration DefaultDartConfiguration = new()
         {
             Name = "Test",
             Dart = new DartConfiguration { },
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/Dart/ContractsGeneratorTests.ClassGeneration.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/Dart/ContractsGeneratorTests.ClassGeneration.cs
@@ -3,7 +3,7 @@
 
 namespace LeanCode.ContractsGenerator.Tests.Dart
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_ClassGeneration
     {
         [Fact]
         public void Private_class_is_not_resolved()
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/Dart/ContractsGeneratorTests.CommandQueryGeneration.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/Dart/ContractsGeneratorTests.CommandQueryGeneration.cs
@@ -3,7 +3,7 @@
 
 namespace LeanCode.ContractsGenerator.Tests.Dart
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_CommandQueryGeneration
     {
         [Fact]
         public void Remote_query_contains_mapping_from_json_for_DTO()
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/Dart/ContractsGeneratorTests.ConstantsGeneration.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/Dart/ContractsGeneratorTests.ConstantsGeneration.cs
@@ -1,42 +1,52 @@
-using System.Text.RegularExpressions;
 using Xunit;
 using static LeanCode.ContractsGenerator.Tests.Dart.ContractsGeneratorTestHelpers;
 
 namespace LeanCode.ContractsGenerator.Tests.Dart
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_ConstantsGeneration
     {
         [Fact]
-        public void Commands_error_code_is_resolved_correctly()
+        public void Commands_error_code_is_generated()
         {
             var generator = CreateDartGeneratorFromNamespace("public class TestClass : IRemoteCommand { public static class ErrorCodes { public const int Invalid = 1; } }");
 
             var contracts = GetContracts(generator.Generate(DefaultDartConfiguration));
 
-            Assert.Contains("invalid = 1", contracts);
+            Assert.Contains("static const int invalid = 1", contracts);
         }
 
         [Fact]
-        public void Const_in_nested_static_class_is_resolved_correctly()
+        public void Const_in_nested_static_class_is_generated()
         {
             var generator = CreateDartGeneratorFromNamespace("public static class Constants { public static class Constants2 { public const int Value = 1; } }");
 
             var contracts = GetContracts(generator.Generate(DefaultDartConfiguration));
 
             Assert.Contains("Constants {", contracts);
             Assert.Contains("Constants2 {", contracts);
-            Assert.Contains("value = 1", contracts);
+            Assert.Contains("static const int value = 1", contracts);
         }
 
         [Fact]
-        public void Multiple_command_error_codes_are_resolved_correctly()
+        public void Multiple_command_error_codes_are_generated()
         {
             var generator = CreateDartGeneratorFromNamespace("public class TestClass : IRemoteCommand { public static class ErrorCodes { public const int Invalid = 1; public const int Empty = 2; } }");
 
             var contracts = GetContracts(generator.Generate(DefaultDartConfiguration));
 
-            Assert.Contains("invalid = 1", contracts);
-            Assert.Contains("empty = 2", contracts);
+            Assert.Contains("static const int invalid = 1", contracts);
+            Assert.Contains("static const int empty = 2", contracts);
+        }
+
+        [Fact]
+        public void Constants_in_static_classes_are_generated()
+        {
+            var generator = CreateDartGeneratorFromNamespace("public static class StaticClass { public const int SomeConstant = 1; }");
+
+            var contracts = GetContracts(generator.Generate(DefaultDartConfiguration));
+
+            Assert.Contains("StaticClass {", contracts);
+            Assert.Contains("static const int someConstant = 1", contracts);
         }
     }
 }
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/Dart/ContractsGeneratorTests.EnumGeneration.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/Dart/ContractsGeneratorTests.EnumGeneration.cs
@@ -3,7 +3,7 @@
 
 namespace LeanCode.ContractsGenerator.Tests.Dart
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_EnumGeneration
     {
         [Fact]
         public void Enums_have_correct_values()
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/Dart/ContractsGeneratorTests.MultilinePreambles.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/Dart/ContractsGeneratorTests.MultilinePreambles.cs
@@ -3,7 +3,7 @@
 
 namespace LeanCode.ContractsGenerator.Tests.Dart
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_MultilinePreambles
     {
         [Fact]
         public void Empty_configuration_contains_default_preamble()
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/Dart/ContractsGeneratorTests.TypesGeneration.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/Dart/ContractsGeneratorTests.TypesGeneration.cs
@@ -4,7 +4,7 @@
 
 namespace LeanCode.ContractsGenerator.Tests.Dart
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_TypesGeneration
     {
         [Fact]
         public void Imports_are_generated()
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/LeanCode.ContractsGenerator.Tests.csproj b/test/Tools/LeanCode.ContractsGenerator.Tests/LeanCode.ContractsGenerator.Tests.csproj
@@ -4,8 +4,4 @@
     <ProjectReference Include="../../../src/Tools/LeanCode.ContractsGenerator/LeanCode.ContractsGenerator.csproj" />
   </ItemGroup>
 
-  <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis" />
-  </ItemGroup>
-
 </Project>
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTestHelpers.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTestHelpers.cs
@@ -31,7 +31,7 @@ namespace {namespaceName}
             ");
         }
 
-        public static readonly GeneratorConfiguration DefaultTypeScriptConfiguration = new GeneratorConfiguration()
+        public static readonly GeneratorConfiguration DefaultTypeScriptConfiguration = new()
         {
             Name = "Test",
             TypeScript = new TypeScriptConfiguration
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.ClassGeneration.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.ClassGeneration.cs
@@ -3,7 +3,7 @@
 
 namespace LeanCode.ContractsGenerator.Tests.TypeScript
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_ClassGeneration
     {
         [Fact]
         public void Private_class_is_not_resolved()
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.CommandQueryGeneration.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.CommandQueryGeneration.cs
@@ -3,7 +3,7 @@
 
 namespace LeanCode.ContractsGenerator.Tests.TypeScript
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_CommandQueryGeneration
     {
         [Fact]
         public void Namespace_name_with_one_element_is_resolved_correctly()
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.ConstantsGeneration.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.ConstantsGeneration.cs
@@ -1,10 +1,9 @@
-using System.Text.RegularExpressions;
 using Xunit;
 using static LeanCode.ContractsGenerator.Tests.TypeScript.ContractsGeneratorTestHelpers;
 
 namespace LeanCode.ContractsGenerator.Tests.TypeScript
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_ConstantsGeneration
     {
         [Fact]
         public void Commands_error_code_is_resolved_correctly()
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.EnumGeneration.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.EnumGeneration.cs
@@ -3,7 +3,7 @@
 
 namespace LeanCode.ContractsGenerator.Tests.TypeScript
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_EnumGeneration
     {
         [Fact]
         public void Simple_enum_is_generated_correctly()
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.ErrorCodes.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.ErrorCodes.cs
@@ -3,7 +3,7 @@
 
 namespace LeanCode.ContractsGenerator.Tests.TypeScript
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_ErrorCodes
     {
         [Fact]
         public void ErrorCodes_are_resolved_correctly_with_default_config()
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.MultilinePreambles.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.MultilinePreambles.cs
@@ -3,7 +3,7 @@
 
 namespace LeanCode.ContractsGenerator.Tests.TypeScript
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_MultilinePreambles
     {
         [Fact]
         public void Empty_configuration_contains_default_preambles()
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.NestedTypes.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.NestedTypes.cs
@@ -3,7 +3,7 @@
 
 namespace LeanCode.ContractsGenerator.Tests.TypeScript
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_NestedTypes
     {
         [Fact]
         public void Generates_globals_if_type_has_consts()
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.TypesExclusion.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.TypesExclusion.cs
@@ -3,7 +3,7 @@
 
 namespace LeanCode.ContractsGenerator.Tests.TypeScript
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_TypesExclusion
     {
         [Theory]
         [InlineData("class")]
diff --git a/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.TypesGeneration.cs b/test/Tools/LeanCode.ContractsGenerator.Tests/TypeScript/ContractsGeneratorTests.TypesGeneration.cs
@@ -3,7 +3,7 @@
 
 namespace LeanCode.ContractsGenerator.Tests.TypeScript
 {
-    public partial class ContractsGeneratorTests
+    public class ContractsGeneratorTests_TypesGeneration
     {
         [Fact]
         public void Int_is_resolved_to_number()

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ namespace {namespaceName}`
`32`	`32`	`");`
`33`	`33`	`}`
`34`	`34`
`35`		`- public static readonly GeneratorConfiguration DefaultDartConfiguration = new GeneratorConfiguration()`
	`35`	`+ public static readonly GeneratorConfiguration DefaultDartConfiguration = new()`
`36`	`36`	`{`
`37`	`37`	`Name = "Test",`
`38`	`38`	`Dart = new DartConfiguration { },`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`
`4`	`4`	`namespace LeanCode.ContractsGenerator.Tests.Dart`
`5`	`5`	`{`
`6`		`- public partial class ContractsGeneratorTests`
	`6`	`+ public class ContractsGeneratorTests_ClassGeneration`
`7`	`7`	`{`
`8`	`8`	`[Fact]`
`9`	`9`	`public void Private_class_is_not_resolved()`
Original file line number	Diff line number	Diff line change
`@@ -1,42 +1,52 @@`
`1`		`-using System.Text.RegularExpressions;`
`2`	`1`	`using Xunit;`
`3`	`2`	`using static LeanCode.ContractsGenerator.Tests.Dart.ContractsGeneratorTestHelpers;`
`4`	`3`
`5`	`4`	`namespace LeanCode.ContractsGenerator.Tests.Dart`
`6`	`5`	`{`
`7`		`- public partial class ContractsGeneratorTests`
	`6`	`+ public class ContractsGeneratorTests_ConstantsGeneration`
`8`	`7`	`{`
`9`	`8`	`[Fact]`
`10`		`- public void Commands_error_code_is_resolved_correctly()`
	`9`	`+ public void Commands_error_code_is_generated()`
`11`	`10`	`{`
`12`	`11`	`var generator = CreateDartGeneratorFromNamespace("public class TestClass : IRemoteCommand { public static class ErrorCodes { public const int Invalid = 1; } }");`
`13`	`12`
`14`	`13`	`var contracts = GetContracts(generator.Generate(DefaultDartConfiguration));`
`15`	`14`
`16`		`- Assert.Contains("invalid = 1", contracts);`
	`15`	`+ Assert.Contains("static const int invalid = 1", contracts);`
`17`	`16`	`}`
`18`	`17`
`19`	`18`	`[Fact]`
`20`		`- public void Const_in_nested_static_class_is_resolved_correctly()`
	`19`	`+ public void Const_in_nested_static_class_is_generated()`
`21`	`20`	`{`
`22`	`21`	`var generator = CreateDartGeneratorFromNamespace("public static class Constants { public static class Constants2 { public const int Value = 1; } }");`
`23`	`22`
`24`	`23`	`var contracts = GetContracts(generator.Generate(DefaultDartConfiguration));`
`25`	`24`
`26`	`25`	`Assert.Contains("Constants {", contracts);`
`27`	`26`	`Assert.Contains("Constants2 {", contracts);`
`28`		`- Assert.Contains("value = 1", contracts);`
	`27`	`+ Assert.Contains("static const int value = 1", contracts);`
`29`	`28`	`}`
`30`	`29`
`31`	`30`	`[Fact]`
`32`		`- public void Multiple_command_error_codes_are_resolved_correctly()`
	`31`	`+ public void Multiple_command_error_codes_are_generated()`
`33`	`32`	`{`
`34`	`33`	`var generator = CreateDartGeneratorFromNamespace("public class TestClass : IRemoteCommand { public static class ErrorCodes { public const int Invalid = 1; public const int Empty = 2; } }");`
`35`	`34`
`36`	`35`	`var contracts = GetContracts(generator.Generate(DefaultDartConfiguration));`
`37`	`36`
`38`		`- Assert.Contains("invalid = 1", contracts);`
`39`		`- Assert.Contains("empty = 2", contracts);`
	`37`	`+ Assert.Contains("static const int invalid = 1", contracts);`
	`38`	`+ Assert.Contains("static const int empty = 2", contracts);`
	`39`	`+ }`
	`40`	`+`
	`41`	`+ [Fact]`
	`42`	`+ public void Constants_in_static_classes_are_generated()`
	`43`	`+ {`
	`44`	`+ var generator = CreateDartGeneratorFromNamespace("public static class StaticClass { public const int SomeConstant = 1; }");`
	`45`	`+`
	`46`	`+ var contracts = GetContracts(generator.Generate(DefaultDartConfiguration));`
	`47`	`+`
	`48`	`+ Assert.Contains("StaticClass {", contracts);`
	`49`	`+ Assert.Contains("static const int someConstant = 1", contracts);`
`40`	`50`	`}`
`41`	`51`	`}`
`42`	`52`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`namespace LeanCode.ContractsGenerator.Tests.Dart`
`6`	`6`	`{`
`7`		`- public partial class ContractsGeneratorTests`
	`7`	`+ public class ContractsGeneratorTests_TypesGeneration`
`8`	`8`	`{`
`9`	`9`	`[Fact]`
`10`	`10`	`public void Imports_are_generated()`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ namespace {namespaceName}`
`31`	`31`	`");`
`32`	`32`	`}`
`33`	`33`
`34`		`- public static readonly GeneratorConfiguration DefaultTypeScriptConfiguration = new GeneratorConfiguration()`
	`34`	`+ public static readonly GeneratorConfiguration DefaultTypeScriptConfiguration = new()`
`35`	`35`	`{`
`36`	`36`	`Name = "Test",`
`37`	`37`	`TypeScript = new TypeScriptConfiguration`