Skip to content

Commit 94acd44

Browse files
committed
toc= was not accepted by webshot_shiny(). Corrected.
1 parent c5ea926 commit 94acd44

4 files changed

Lines changed: 11 additions & 3 deletions

File tree

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: learndown
22
Type: Package
3-
Version: 1.1.1
3+
Version: 1.1.2
44
Title: 'SciViews' - R Markdown and Bookdown Additions for Learning Material
55
Description: Extension to R Markdown and Bookdown for building better learning
66
and e-learning material: H5P integration, course-contextual divs, different

NEWS.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# learndown 1.1.2
2+
3+
- `webshot_shiny()` refused to work when it sees the `toc =` argument. Solved.
4+
15
# learndown 1.1.1
26

37
- Anchors now include `part` for `assignation()`, so that different anchors are

R/webshot_shiny.R

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#' @param delay Time to wait (in sec) after the Shiny application has started
2424
#' and before the screenshot is taken. If the screenshot does not contain the
2525
#' complete application UI, try increase this value.
26+
#' @param ... Further arguments passed to [launch_shiny()] but not used here.
2627
#'
2728
#' @return The path to the created image, invisibly.
2829
#' @export
@@ -36,7 +37,7 @@
3637
#'}
3738
webshot_shiny <- function(url, app = basename(url),
3839
imgdir = "images/shinyapps", img = paste0(imgdir, "/", app, ".png"),
39-
width = 780, height = 500, offsetx = 30, offsety = 30, delay = 10) {
40+
width = 780, height = 500, offsetx = 30, offsety = 30, delay = 10, ...) {
4041
# Make sure imgdir directory exists
4142
dir.create(imgdir, showWarnings = FALSE, recursive = TRUE)
4243

man/webshot_shiny.Rd

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)