From b423331e3ac22a39acd1bcb2e2a120474a0e4bfe Mon Sep 17 00:00:00 2001
From: Hans Rakers <h.rakers@global.leaseweb.com>
Date: Tue, 27 Oct 2026 11:01:59 +0100
Subject: [PATCH] ci: Create releases with softprops/action-gh-release

Switch the release step from gh release create to
softprops/action-gh-release@v3, matching cloudstack-kubernetes-provider.
Give the release job contents: write explicitly, and generate release
notes from the merged PRs instead of leaving them empty.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
 .github/workflows/release.yaml | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
index 9be05b2..56b8949 100644
--- a/.github/workflows/release.yaml
+++ b/.github/workflows/release.yaml
@@ -71,6 +71,10 @@ jobs:
     name: Release
     runs-on: ubuntu-24.04
 
+    # Needed by softprops/action-gh-release to create the release and upload assets
+    permissions:
+      contents: write
+
     # Run only if previous job has succeeded
     needs: [push]
 
@@ -99,13 +103,15 @@ jobs:
           name: bin
           path: bin
 
-      - name: Create Release
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          gh release create "${{ github.ref_name }}" \
-            --title "${{ github.ref_name }}" \
-            --notes "" \
-            --verify-tag \
-            manifest.yaml \
+      # tag_name and name both default to github.ref_name, so the release is
+      # titled with the bare tag (v1.2.3) rather than the full ref.
+      - name: Create release
+        uses: softprops/action-gh-release@v3
+        with:
+          files: |
+            manifest.yaml
             bin/cloudstack-csi-sc-syncer
+          generate_release_notes: true
+          fail_on_unmatched_files: true
+          draft: false
+          prerelease: false