tests: Add performance test for string iteration

Signed-off-by: Alexey Gladkov <legion@kernel.org>

Author: legionus

.github/workflows/lint.yml

@@ -56,7 +56,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: "install tools"
-        run: sudo apt-get -y -qq install dash
+        run: sudo apt-get -y -qq install dash bash mksh
       - name: "unittests"
         run: make check CHECK_SHELL=/bin/dash V=1
 
@@ -66,7 +66,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: "install tools"
-        run: sudo apt-get -y -qq install bash
+        run: sudo apt-get -y -qq install dash bash mksh
       - name: "unittests"
         run: make check CHECK_SHELL=/bin/bash V=1
 
@@ -76,6 +76,6 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: "install tools"
-        run: sudo apt-get -y -qq install mksh
+        run: sudo apt-get -y -qq install dash bash mksh
       - name: "unittests"
         run: make check CHECK_SHELL=/bin/mksh V=1

Makefile

@@ -85,6 +85,7 @@ check:
 	@cd tests; \
 	    for sh in $${CHECK_SHELL:-/bin/sh /bin/dash /bin/bash /bin/bash3 /bin/bash4 /bin/mksh /bin/yash /bin/pdksh}; do \
 	    [ -x "$$sh" ] || continue; \
+	    export TEST_SHELL="$$sh"; \
 	    echo "Running tests with $$sh"; \
 	    if ! "$$sh" -efu ./runtests; then \
 	        echo "Tests failed with $$sh"; \

tests/check-string-performance

@@ -0,0 +1,69 @@
+#!/bin/sh -efu
+
+get_user_time()
+{
+	# 0m0.099s 0m0.095s
+
+	local user_time system_time
+	read -r user_time system_time ||:
+
+	user_time="${user_time%.*}"
+
+	echo "$user_time"
+}
+
+string_performance_test1() { # UnitTest
+	. ../shell-string
+
+	local i p s dash_shell
+
+	case "${TEST_SHELL##*/}" in
+		ash|dash)
+			shouldSkip
+			;;
+	esac
+
+
+	for i in ash dash; do
+		dash_shell="$(which "$i" 2>/dev/null)" && break ||:
+	done
+
+	[ -n "$dash_shell" ] ||
+		shouldSkip
+
+	p="1234567890AaBbCcDdEeFfGgHhIiJjKkLlMmNnOoPpQqRrSsTtUuVvWwXxYyZz"
+	s=
+	for i in \
+		0 1 2 3 4 5 6 7 8 9 \
+		0 1 2 3 4 5 6 7 8 9 \
+		0 1 2 3 4 5 6 7 8 9 \
+		0 1 2 3 4 5 6 7 8 9 \
+		0 1 2 3 4 5 6 7 8 9 \
+		0 1 2 3 4 5 6 7 8 9 \
+		0 1 2 3 4 5 6 7 8 9 \
+		0 1 2 3 4 5 6 7 8 9 \
+		;
+	do
+		s="$s$p"
+	done
+
+	export string="$s"
+
+	local result_dash result_test
+
+	result_dash="$($dash_shell -efu ./string-data/iterate-string.sh | get_user_time)"
+	result_test="$($TEST_SHELL -efu ./string-data/iterate-string.sh | get_user_time)"
+
+	assertTrue "$TEST_SHELL ran a minutes longer: $dash_shell: $result_dash, $TEST_SHELL: $result_test" \
+		"test ${result_dash%m*} -ge ${result_test%m*}"
+
+	assertTrue "$TEST_SHELL ran a seconds longer: $dash_shell: $result_dash, $TEST_SHELL: $result_test" \
+		"test ${result_dash#*m} -ge ${result_test#*m}"
+
+	case "${TEST_SHELL##*/}" in
+		bash*|*ksh)
+			assertTrue "$TEST_SHELL is too slow: $result_test" \
+				"test ${result_test%m*} -eq 0 -a ${result_test#*m} -lt 3"
+			;;
+	esac
+}

tests/runtests

@@ -21,6 +21,7 @@ tearDownTests() {
 }
 
 for s in \
+	check-string-performance \
 	quote_sed_regexp quote_shell string_quote_remove \
 	opt_check_dir opt_check_number opt_check_read \
 	quote_sed_regexp_variable quote_shell_variable \

tests/string-data/iterate-string.sh

@@ -0,0 +1,11 @@
+#!/bin/dash -efu
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+. ../shell-string
+
+__shell_string_foreach_prepare ctx "$string"
+while __shell_string_foreach_continue "$ctx"; do
+	__shell_string_foreach_char c "$ctx"
+	__shell_string_foreach_iter "$ctx"
+done
+times