Fix Minor Issues

Author: leimao

README.md

@@ -33,7 +33,7 @@ $ cmake -B build
 $ cmake --build build --config Release --parallel
 ```
 
-Under the `build/src/plugins` directory, the custom plugin library will be saved as `libidentity_conv_iplugin_v2_io_ext.so` for `IPluginV2Ext` and `libidentity_conv_iplugin_v3.so` for `IPluginV3`, respectively. The `IPluginV2Ext` has been deprecated since TensorRT 10.0.0 and will be removed in the future. The `IPluginV3` is the only recommended interface for custom plugin development.
+Under the `build/src/plugins` directory, the custom plugin library will be saved as `libidentity_conv_iplugin_v2_io_ext.so` for `IPluginV2Ext` and `libidentity_conv_iplugin_v3.so` for `IPluginV3`, respectively. The `IPluginV2Ext` plugin interface has been deprecated since TensorRT 10.0.0 and will be removed in the future. The `IPluginV3` plugin interface is the only recommended interface for custom plugin development.
 
 Under the `build/src/apps` directory, the engine builder will be saved as `build_engine`, and the engine runner will be saved as `run_engine`.
 

python/README.md

@@ -2,11 +2,13 @@
 
 ## Unit Test
 
+Assuming the `IPluginV2IOExt` and `IPluginV3` plugins have been built, the engine that uses each of the plugins have been built, the unit tests can be run.
+
 To run the unit test, please run the following command.
 
 ```bash
-python -m unittest test_plugin
-python -m unittest test_engine
+$ python -m unittest test_plugin
+$ python -m unittest test_engine
 ```
 
 ## Run TensorRT Engine

src/CMakeLists.txt

@@ -1,18 +1,9 @@
 cmake_minimum_required(VERSION 3.28)
 
-project(TENSORRT-CUSTOM-PLUGIN-IDENTITY-CONV-EXAMPLE VERSION 0.0.1 LANGUAGES CXX CUDA)
+project(TENSORRT-CUSTOM-PLUGIN-IDENTITY-CONV-EXAMPLE VERSION 0.0.1 LANGUAGES CXX)
 
 set(CMAKE_CXX_STANDARD 14)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
-# Find CUDA Toolkit
-find_package(CUDAToolkit REQUIRED)
-
-# add_executable(build_engine build_engine.cpp)
-# target_link_libraries(build_engine PRIVATE ${NVINFER_LIB} ${NVONNXPARSER_LIB} ${NVINFER_PLUGIN_LIB} CUDA::cudart)
-
-# add_executable(run_engine run_engine.cpp)
-# target_link_libraries(run_engine PRIVATE ${NVINFER_LIB} CUDA::cudart)
-
 add_subdirectory(plugins)
 add_subdirectory(apps)

src/apps/build_engine.cpp

@@ -71,6 +71,9 @@ int main(int argc, char** argv)
 
     // Create the network.
     uint32_t flag{0U};
+    // For TensorRT < 10.0, explicit dimension has to be specified to
+    // distinguish from the implicit dimension. For TensorRT >= 10.0, explicit
+    // dimension is the only choice and this flag has been deprecated.
     if (getInferLibVersion() < 100000)
     {
         flag |= 1U << static_cast<uint32_t>(

src/plugins/IdentityConvIPluginV3/IdentityConvPlugin.cpp

@@ -15,28 +15,6 @@ namespace nvinfer1
 namespace plugin
 {
 
-// TODO(leimao): Handle noexcept later.
-
-// Write values into buffer
-template <typename Type, typename BufferType>
-void write(BufferType*& buffer, Type const& val)
-{
-    static_assert(sizeof(BufferType) == 1, "BufferType must be a 1 byte type.");
-    std::memcpy(buffer, &val, sizeof(Type));
-    buffer += sizeof(Type);
-}
-
-// Read values from buffer
-template <typename OutType, typename BufferType>
-OutType read(BufferType const*& buffer)
-{
-    static_assert(sizeof(BufferType) == 1, "BufferType must be a 1 byte type.");
-    OutType val{};
-    std::memcpy(&val, static_cast<void const*>(buffer), sizeof(OutType));
-    buffer += sizeof(OutType);
-    return val;
-}
-
 IdentityConv::IdentityConv(IdentityConvParameters const& params)
     : mParams{params}
 {
@@ -85,7 +63,6 @@ IPluginV3* IdentityConv::clone() noexcept
     try
     {
         IPluginV3* const plugin{new IdentityConv{mParams}};
-        // plugin->setPluginNamespace(mPluginNamespace);
         return plugin;
     }
     catch (std::exception const& e)

src/plugins/IdentityConvIPluginV3/IdentityConvPlugin.h

@@ -9,6 +9,8 @@
 #include <NvInferRuntime.h>
 #include <NvInferRuntimePlugin.h>
 
+// In IPluginV3 interface, the plugin name, version, and name space must be
+// specified for the plugin and plugin creator exactly the same.
 constexpr char const* const kIDENTITY_CONV_PLUGIN_NAME{"IdentityConv"};
 constexpr char const* const kIDENTITY_CONV_PLUGIN_VERSION{"1"};
 constexpr char const* const kIDENTITY_CONV_PLUGIN_NAMESPACE{""};

src/plugins/IdentityConvIPluginV3/PluginRegistration.h

@@ -7,7 +7,7 @@
 
 extern "C" void setLoggerFinder(nvinfer1::ILoggerFinder* finder);
 
-extern "C" nvinfer1::IPluginCreator* const*
+extern "C" nvinfer1::IPluginCreatorInterface* const*
 getPluginCreators(int32_t& nbCreators);
 
 #endif // TENSORRT_PLUGIN_REGISTRATION_H