refactor: use enhanced instanceof

Author: welschsn

src/main/java/org/jadice/filetype/matchers/PDFMatcher.java

@@ -189,11 +189,9 @@ private void provideXMPMetadata(final Map<String, Object> pdfDetails, final PDMe
 
   private static void extractFilesFromPage(final PDPage page, final List<String> filenames) throws IOException {
     for (PDAnnotation annotation : page.getAnnotations()) {
-      if (annotation instanceof PDAnnotationFileAttachment) {
-        PDAnnotationFileAttachment annotationFileAttachment = (PDAnnotationFileAttachment) annotation;
+      if (annotation instanceof PDAnnotationFileAttachment annotationFileAttachment) {
         PDFileSpecification fileSpec = annotationFileAttachment.getFile();
-        if (fileSpec instanceof PDComplexFileSpecification) {
-          PDComplexFileSpecification complexFileSpec = (PDComplexFileSpecification) fileSpec;
+        if (fileSpec instanceof PDComplexFileSpecification complexFileSpec) {
           PDEmbeddedFile embeddedFile = getEmbeddedFile(complexFileSpec);
           if (embeddedFile != null) {
             extractFile(filenames, complexFileSpec.getFilename());
@@ -291,11 +289,11 @@ private static void addTextInfo(final Map<String, Object> pdfDetails, final PDDo
    */
   private static void checkIfXRechnung(final Map<String, Object> pdfDetails) {
     final Object metadata = pdfDetails.get(METADATA_KEY);
-    if (metadata instanceof String) {
+    if (metadata instanceof String metadataString) {
       try {
         final XMLMatcher xmlMatcher = new XMLMatcher();
         final Context xmlContext = new Context(
-            new MemoryInputStream(((String) metadata).getBytes(StandardCharsets.UTF_8)),
+            new MemoryInputStream(metadataString.getBytes(StandardCharsets.UTF_8)),
             new HashMap<>(), null, Locale.ENGLISH, "");
         final boolean isXRechnung = xmlMatcher.matches(xmlContext);
         if (isXRechnung) {

src/main/java/org/jadice/filetype/matchers/XMLMatcher.java

@@ -182,8 +182,10 @@ private boolean hasXmlProlog(final SeekableInputStream sis) throws IOException {
    *         {@link ByteOrderMark BOM}
    */
   private InputStreamReader createReader(final SeekableInputStream sis) throws IOException {
-    final BOMInputStream bomIS = new BOMInputStream(sis, ByteOrderMark.UTF_8, ByteOrderMark.UTF_16LE,
-        ByteOrderMark.UTF_16BE, ByteOrderMark.UTF_32LE, ByteOrderMark.UTF_32BE);
+    final BOMInputStream bomIS = BOMInputStream.builder().setInputStream(sis)
+        .setByteOrderMarks(ByteOrderMark.UTF_8, ByteOrderMark.UTF_16LE,
+            ByteOrderMark.UTF_16BE, ByteOrderMark.UTF_32LE, ByteOrderMark.UTF_32BE)
+        .get();
 
     final Charset charset;
     if (bomIS.hasBOM()) {
@@ -323,7 +325,7 @@ private static void trySetXercesSecurityManager(SAXParser parser) {
             //"com.sun.org.apache.xerces.internal.util.SecurityManager",
             XERCES_SECURITY_MANAGER}) {
       try {
-        Object mgr = Class.forName(securityManagerClassName).newInstance();
+        Object mgr = Class.forName(securityManagerClassName).getDeclaredConstructor().newInstance();
         Method setLimit = mgr.getClass().getMethod("setEntityExpansionLimit", Integer.TYPE);
         setLimit.invoke(mgr, MAX_ENTITY_EXPANSIONS);