Update, review

Author: liach

src/java.base/share/classes/java/lang/NullPointerException.java

@@ -56,6 +56,7 @@ public class NullPointerException extends RuntimeException {
      * Constructs a {@code NullPointerException} with no detail message.
      */
     public NullPointerException() {
+        extendedMessageState = 0;
         super();
         extendedMessageState |= CONSTRUCTOR_FINISHED;
     }
@@ -67,15 +68,18 @@ public NullPointerException() {
      * @param   s   the detail message.
      */
     public NullPointerException(String s) {
+        extendedMessageState = 0;
         super(s);
         extendedMessageState |= CONSTRUCTOR_FINISHED;
     }
 
+
     // Creates an NPE with a custom backtrace configuration.
     // The exception has no message if detailed NPE is not enabled.
     NullPointerException(int stackOffset, int searchSlot) {
         extendedMessageState = setupCustomBackTrace(stackOffset, searchSlot);
-        this();
+        super();
+        extendedMessageState |= CONSTRUCTOR_FINISHED;
     }
 
     private static int setupCustomBackTrace(int stackOffset, int searchSlot) {

test/hotspot/jtreg/runtime/exceptionMsgs/NullPointerException/NullCheckAPITest.java

@@ -54,15 +54,15 @@ static void nullCheck(Object arg) {
         if (arg == null) {
             if (NESTED_THROW) {
                 // 2 offset: nullCheck, throwNpe;
-                throwNpe();
+                throwNullPointerException();
             } else {
                 // 1 offset: nullCheck
                 throw JLA.extendedNullPointerException(1, 0);
             }
         }
     }
 
-    static void throwNpe() {
+    static void throwNullPointerException() {
         throw JLA.extendedNullPointerException(2, 0);
     }
 
@@ -90,8 +90,8 @@ class Dummy { Object field; }
 
     @Test
     void test() {
-        checkSimpleMessage(() -> generateVariableNpe(null), "myA");
-        checkSimpleMessage(() -> generateVariableNpe(new Dummy()), "myA.field");
+        checkSimpleMessage(() -> generateVariableNullPointerException(null), "myA");
+        checkSimpleMessage(() -> generateVariableNullPointerException(new Dummy()), "myA.field");
 
         checkInvocationMessage(() -> nullCheck(int.class.getSuperclass()), "java.lang.Class.getSuperclass()");
     }
@@ -130,7 +130,7 @@ void testRequireNonNull() {
     }
 
     // A method that generate NPE from variables
-    static void generateVariableNpe(Dummy myA) {
+    static void generateVariableNullPointerException(Dummy myA) {
         nullCheck(myA);
         nullCheck(myA.field);
     }