Review

Author: liach

make/jdk/src/classes/build/tools/methodhandle/VarHandleGuardMethodGenerator.java

@@ -142,7 +142,7 @@ final class VarHandleGuards {
                         } else if (direct && handle.vform.getMethodType_V(ad.type) == ad.symbolicMethodTypeErased) {
                             MethodHandle.linkToStatic(<LINK_TO_STATIC_ARGS>);
                         } else {
-                            <RETURN>ad.adaptedMethodHandle(handle).invokeBasic(<LINK_TO_INVOKER_ARGS>);
+                            ad.adaptedMethodHandle(handle).invokeBasic(<LINK_TO_INVOKER_ARGS>);
                         }
                     }""";
 

src/java.base/share/classes/java/lang/invoke/MethodHandle.java

@@ -980,7 +980,7 @@ private static boolean isAncestorLoaderOf(ClassLoader ancestor, ClassLoader desc
         return false; // no direct relation between loaders is found
     }
 
-    static boolean isBuiltinLoader(ClassLoader loader) {
+    private static boolean isBuiltinLoader(ClassLoader loader) {
         return loader == null ||
                loader == ClassLoaders.platformClassLoader() ||
                loader == ClassLoaders.appClassLoader();

src/java.base/share/classes/java/lang/invoke/SegmentVarHandle.java

@@ -64,6 +64,11 @@ final MethodType accessModeTypeUncached(VarHandle.AccessType accessType) {
                 : accessType.accessModeType(MemorySegment.class, getType.returnType(), long.class, long.class);
     }
 
+    @Override
+    boolean isReachableFrom(ClassLoader cl) {
+        return true;
+    }
+
     @Override
     public SegmentVarHandle withInvokeExactBehavior() {
         return hasInvokeExactBehavior() ?

src/java.base/share/classes/java/lang/invoke/VarHandle.java

@@ -2012,10 +2012,7 @@ static AccessMode valueFromOrdinal(int mode) {
     // Exists for the adaption mechanism of AccessDescriptor
     // Each VH should report its explicitly (receiver, coordinates) and
     // implicitly (static declaring class) used class to MethodHandle.isReachableFrom
-    boolean isReachableFrom(ClassLoader cl) {
-        // Call MethodHandle.isReachableFrom for the used classes
-        return true;
-    }
+    abstract boolean isReachableFrom(ClassLoader cl);
 
     static final class AccessDescriptor {
         final MethodType symbolicMethodTypeExact;

src/java.base/share/classes/java/lang/invoke/X-VarHandle.java.template

@@ -789,6 +789,11 @@ final class VarHandle$Type$s {
             return at.accessModeType({#if[Object]?arrayType:$type$[].class}, {#if[Object]?arrayType.getComponentType():$type$.class}, int.class);
         }
 
+        @Override
+        boolean isReachableFrom(ClassLoader cl) {
+            return {#if[Object]?MethodHandle.isReachableFrom(arrayType, cl):true};
+        }
+
 #if[Object]
         @ForceInline
         static Object runtimeTypeCheck(Array handle, Object[] oarray, Object value) {

src/java.base/share/classes/java/lang/invoke/X-VarHandleByteArrayView.java.template

@@ -79,6 +79,11 @@ final class VarHandleByteArrayAs$Type$s extends VarHandleByteArrayBase {
             super(form, exact);
             this.be = be;
         }
+
+        @Override
+        boolean isReachableFrom(ClassLoader cl) {
+            return true;
+        }
     }
 
     static final class ArrayHandle extends ByteArrayViewVarHandle {