Merge pull request #3572 from roystgnr/poly2tri_work

Poly2TriTriangulator refinement fixes

Author: roystgnr

include/geom/cell_hex.h

@@ -172,7 +172,7 @@ class Hex : public Cell
    */
   virtual unsigned int n_permutations() const override final { return 24; }
 
-  virtual void orient(BoundaryInfo *) override final;
+  virtual bool is_flipped() const override final;
 
   /**
    * This maps each edge to the sides that contain said edge.

include/geom/cell_inf_hex.h

@@ -187,7 +187,7 @@ class InfHex : public InfCell
    */
   virtual unsigned int n_permutations() const override final { return 4; }
 
-  virtual void orient(BoundaryInfo *) override final;
+  virtual bool is_flipped() const override final;
 
   /**
    * This maps each edge to the sides that contain said edge.

include/geom/cell_inf_prism.h

@@ -171,7 +171,7 @@ class InfPrism : public InfCell
 
   std::vector<unsigned int> sides_on_edge(const unsigned int e) const override final;
 
-  virtual void orient(BoundaryInfo *) override final;
+  virtual bool is_flipped() const override final;
 
   /**
    * This maps each edge to the sides that contain said edge.

include/geom/cell_prism.h

@@ -151,7 +151,7 @@ class Prism : public Cell
    */
   virtual unsigned int n_permutations() const override final { return 6; }
 
-  virtual void orient(BoundaryInfo *) override final;
+  virtual bool is_flipped() const override final;
 
   /**
    * This maps each edge to the sides that contain said edge.

include/geom/cell_pyramid.h

@@ -175,7 +175,7 @@ class Pyramid : public Cell
    */
   virtual unsigned int n_permutations() const override final { return 4; }
 
-  virtual void orient(BoundaryInfo *) override final;
+  virtual bool is_flipped() const override final;
 
   /**
    * This maps each edge to the sides that contain said edge.

include/geom/cell_tet.h

@@ -196,7 +196,7 @@ class Tet : public Cell
    */
   virtual unsigned int n_permutations() const override final { return 12; }
 
-  virtual void orient(BoundaryInfo *) override final;
+  virtual bool is_flipped() const override final;
 
   /**
    * This maps each edge to the sides that contain said edge.

include/geom/edge.h

@@ -202,7 +202,7 @@ class Edge : public Elem
 
   virtual void permute(unsigned int) override final { libmesh_error(); }
 
-  virtual void orient(BoundaryInfo *) override final;
+  virtual bool is_flipped() const override final;
 
   unsigned int center_node_on_side(const unsigned short side) const override final;
 

include/geom/elem.h

@@ -1798,13 +1798,25 @@ class Elem : public ReferenceCountedObject<Elem>,
    */
   virtual void flip(BoundaryInfo * boundary_info) = 0;
 
+  /**
+   * \returns Whether the element is flipped compared to standard
+   * libMesh (e.g. clockwise for 2D elements) node orientations.
+   *
+   * Always returns \p false if a 2D element is not in the XY plane or
+   * a 1D element is not on the X axis; user code designed to work for
+   * embedded manifolds should handle any consistent orientation, and
+   * determining whether an orientation is consistent is not a local
+   * operation.
+   */
+   virtual bool is_flipped() const = 0;
+
   /**
    * Flips the element (by swapping node and neighbor pointers) to
    * have a mapping Jacobian of opposite sign, iff we find a negative
    * orientation.  This only fixes flipped elements; for tangled
    * elements the only fixes possible are non-local.
    */
-  virtual void orient(BoundaryInfo * boundary_info) = 0;
+  void orient(BoundaryInfo * boundary_info);
 
 #ifdef LIBMESH_ENABLE_AMR
 
@@ -3079,6 +3091,14 @@ void Elem::hack_p_level_and_refinement_flag (unsigned int p,
 #endif // ifdef LIBMESH_ENABLE_AMR
 
 
+inline
+void Elem::orient(BoundaryInfo * boundary_info)
+{
+  if (this->is_flipped())
+    this->flip(boundary_info);
+}
+
+
 inline
 dof_id_type Elem::compute_key (dof_id_type n0)
 {

include/geom/face_inf_quad.h

@@ -231,7 +231,7 @@ class InfQuad : public Elem
 
   virtual void permute(unsigned int) override final { libmesh_error(); }
 
-  virtual void orient(BoundaryInfo *) override final;
+  virtual bool is_flipped() const override final;
 
 protected:
 

include/geom/face_quad.h

@@ -188,7 +188,7 @@ class Quad : public Face
    */
   virtual unsigned int n_permutations() const override final { return 4; }
 
-  virtual void orient(BoundaryInfo *) override final;
+  virtual bool is_flipped() const override final;
 
 protected: