Update public accesses of old_dof_object dumb pointer

TODO: this variable should probably be behind an accessor. Perhaps we
can deprecate its public access in a relatively seamless way (see
MeshBase::get_boundary_info()), although technically we are already
breaking backwards compatibility with this change.

Author: jwpeterson

include/systems/generic_projector.h

@@ -887,7 +887,7 @@ class OldSolutionValue : public OldSolutionBase<Output, point_output>
     // zero.
     if (nc != 0)
       {
-        const DofObject *old_dof_object = old_elem.old_dof_object;
+        const DofObject *old_dof_object = old_elem.old_dof_object.get();
         libmesh_assert(old_dof_object);
         libmesh_assert_greater(elem.n_systems(), sys_num);
 

src/base/dof_map.C

@@ -2260,7 +2260,7 @@ void DofMap::old_dof_indices (const Elem & elem,
                               std::vector<dof_id_type> & di,
                               const unsigned int vn) const
 {
-  const DofObject * old_obj = elem.node_ref(n).old_dof_object;
+  const DofObject * old_obj = elem.node_ref(n).old_dof_object.get();
   libmesh_assert(old_obj);
   this->_node_dof_indices(elem, n, *old_obj, di, vn);
 }
@@ -2687,7 +2687,7 @@ void DofMap::old_dof_indices (const Elem * const elem,
                     for (unsigned int n=0; n<n_nodes; n++)
                       {
                         const Node * node = nodes_ptr[n];
-                        const DofObject * old_dof_obj = node->old_dof_object;
+                        const DofObject * old_dof_obj = node->old_dof_object.get();
                         libmesh_assert(old_dof_obj);
 
                         // There is a potential problem with h refinement.  Imagine a
@@ -2765,7 +2765,7 @@ void DofMap::old_dof_indices (const Elem * const elem,
 
                     if (nc != 0)
                       {
-                        const DofObject * old_dof_obj = elem->old_dof_object;
+                        const DofObject * old_dof_obj = elem->old_dof_object.get();
                         libmesh_assert(old_dof_obj);
 
                         const unsigned int n_comp =

src/systems/system_projection.C

@@ -1379,7 +1379,7 @@ void BuildProjectionList::operator()(const ConstElemRange & range)
 
           for (auto & node : elem->node_ref_range())
             {
-              const DofObject * old_dofs = node.old_dof_object;
+              const DofObject * old_dofs = node.old_dof_object.get();
 
               if (old_dofs)
                 {