Skip to content

Commit bfeb3ac

Browse files
committed
[RFC] make: remove filesystem flags from dependency builds
It's a link-only setting and since we only build static libs only relevant in the final linking step. RFC: modern emscripten is supposedly able to detect this automatically. If it works, should we also remove it from the final link flags?
1 parent 02ef3e0 commit bfeb3ac

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

Makefile

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ $(DIST_DIR)/lib/libfribidi.a: build/lib/fribidi/configure
2626
CFLAGS=" \
2727
-s USE_PTHREADS=0 \
2828
$(GLOBAL_CFLAGS) \
29-
-s NO_FILESYSTEM=1 \
3029
-DFRIBIDI_ENTRY=extern \
3130
" \
3231
--prefix="$(DIST_DIR)" \
@@ -50,7 +49,6 @@ $(DIST_DIR)/lib/libexpat.a: build/lib/expat/configured
5049
-DCMAKE_C_FLAGS=" \
5150
-s USE_PTHREADS=0 \
5251
$(GLOBAL_CFLAGS) \
53-
-s NO_FILESYSTEM=1 \
5452
" \
5553
-DCMAKE_INSTALL_PREFIX=$(DIST_DIR) \
5654
-DEXPAT_BUILD_DOCS=off \
@@ -110,7 +108,6 @@ build/lib/freetype/build_hb/dist_hb/lib/libfreetype.a: $(DIST_DIR)/lib/libbrotli
110108
CFLAGS=" \
111109
-s USE_PTHREADS=0 \
112110
$(GLOBAL_CFLAGS) \
113-
-s NO_FILESYSTEM=1 \
114111
" \
115112
--prefix="$$(pwd)/dist_hb" \
116113
--host=x86-none-linux \
@@ -141,13 +138,11 @@ $(DIST_DIR)/lib/libharfbuzz.a: build/lib/freetype/build_hb/dist_hb/lib/libfreety
141138
CFLAGS=" \
142139
-s USE_PTHREADS=0 \
143140
$(GLOBAL_CFLAGS) \
144-
-s NO_FILESYSTEM=1 \
145141
-DHB_NO_MT \
146142
" \
147143
CXXFLAGS=" \
148144
-s USE_PTHREADS=0 \
149145
$(GLOBAL_CFLAGS) \
150-
-s NO_FILESYSTEM=1 \
151146
-DHB_NO_MT \
152147
" \
153148
--prefix="$(DIST_DIR)" \
@@ -174,7 +169,6 @@ $(DIST_DIR)/lib/libfreetype.a: $(DIST_DIR)/lib/libharfbuzz.a $(DIST_DIR)/lib/lib
174169
CFLAGS=" \
175170
-s USE_PTHREADS=0 \
176171
$(GLOBAL_CFLAGS) \
177-
-s NO_FILESYSTEM=1 \
178172
" \
179173
--prefix="$(DIST_DIR)" \
180174
--host=x86-none-linux \

0 commit comments

Comments
 (0)