Merge pull request #952 from evoskuil/master

Move BC_HTTP_SERVER_NAME to network, comments, del stray file.

Author: evoskuil

benchmark.txt

@@ -30,8 +30,6 @@ namespace libbitcoin {
 namespace node {
 
 // TODO: strip extraneous args before electrum version dispatch.
-// TODO: move version_ and name_ members into channel with set/get.
-// TODO: move to electrum version method to handshake protocol.
 /// Channel for electrum channels (non-http json-rpc).
 class BCN_API channel_electrum
   : public node::channel,

include/bitcoin/node/channels/channel_electrum.hpp

@@ -27,7 +27,7 @@ namespace node {
 BCN_API bool bitcoind_query(network::rpc::request_t& out,
     const network::http::request& request) NOEXCEPT;
 
-} // namespace network
+} // namespace node
 } // namespace libbitcoin
 
 #endif

include/bitcoin/node/parsers/bitcoind_query.hpp

@@ -27,7 +27,7 @@ namespace node {
 BCN_API code bitcoind_target(network::rpc::request_t& out,
     const std::string_view& path) NOEXCEPT;
 
-} // namespace network
+} // namespace node
 } // namespace libbitcoin
 
 #endif

include/bitcoin/node/parsers/bitcoind_target.hpp

@@ -66,7 +66,7 @@ enum class electrum_version
     v1_6
 };
 
-} // namespace network
+} // namespace node
 } // namespace libbitcoin
 
 #endif

include/bitcoin/node/parsers/electrum_version.hpp

@@ -27,7 +27,7 @@ namespace node {
 BCN_API bool explore_query(network::rpc::request_t& out,
     const network::http::request& request) NOEXCEPT;
 
-} // namespace network
+} // namespace node
 } // namespace libbitcoin
 
 #endif

include/bitcoin/node/parsers/explore_query.hpp

@@ -27,7 +27,7 @@ namespace node {
 BCN_API code explore_target(network::rpc::request_t& out,
     const std::string_view& path) NOEXCEPT;
 
-} // namespace network
+} // namespace node
 } // namespace libbitcoin
 
 #endif

include/bitcoin/node/parsers/explore_target.hpp

@@ -41,7 +41,7 @@ using session_stratum_v2 = session_server<protocol_stratum_v2>;
 using session_electrum = session_handshake<protocol_electrum_version,
     protocol_electrum>;
 
-} // namespace network
+} // namespace node
 } // namespace libbitcoin
 
 #endif

include/bitcoin/node/sessions/sessions.hpp

@@ -102,7 +102,7 @@ class BCN_API settings
 
 namespace server {
 
-/// HACK: must cast writer to non-const.
+// HACK: must cast writer to non-const.
 using span_value = network::http::span_body::value_type;
 
 /// [server] settings.

include/bitcoin/node/settings.hpp

@@ -22,8 +22,6 @@
 #include <bitcoin/node/configuration.hpp>
 #include <bitcoin/node/settings.hpp>
 
-#define BC_HTTP_SERVER_NAME "libbitcoin/4.0"
-
 ////std::filesystem::path config_default_path() NOEXCEPT
 ////{
 ////    return { "libbitcoin/bn.cfg" };