Attach reject protocol to standard sessions.

Author: evoskuil

src/protocols/protocol_block_in.cpp

@@ -365,6 +365,8 @@ bool protocol_block_in::handle_reorganized(code ec, size_t fork_height,
     if (stopped(ec))
         return false;
 
+    // TODO: differentiate failure conditions and send reject as applicable.
+
     if (ec)
     {
         LOG_ERROR(LOG_NODE)

src/protocols/protocol_transaction_in.cpp

@@ -176,7 +176,9 @@ void protocol_transaction_in::handle_store_transaction(const code& ec,
     // is not generally okay to receive an otherwise invalid transaction.
     // Below-fee transactions can be sent prior to fee_filter receipt or due to
     // a negotiated version below BIP133 (7013).
-    // TODO: differentiate these situations and send reject as applicable.
+
+    // TODO: differentiate failure conditions and send reject as applicable.
+
     if (ec)
     {
         // This should not happen with a single peer since we filter inventory.

src/sessions/session_inbound.cpp

@@ -45,11 +45,16 @@ session_inbound::session_inbound(full_node& network, safe_chain& chain)
 
 void session_inbound::attach_protocols(channel::ptr channel)
 {
-    if (channel->negotiated_version() >= version::level::bip31)
+    const auto version = channel->negotiated_version();
+
+    if (version >= version::level::bip31)
         attach<protocol_ping_60001>(channel)->start();
     else
         attach<protocol_ping_31402>(channel)->start();
 
+    if (version >= message::version::level::bip61)
+        attach<protocol_reject_70002>(channel)->start();
+
     attach<protocol_address_31402>(channel)->start();
     attach<protocol_block_in>(channel, chain_)->start();
     attach<protocol_block_out>(channel, chain_)->start();

src/sessions/session_manual.cpp

@@ -45,11 +45,16 @@ session_manual::session_manual(full_node& network, safe_chain& chain)
 
 void session_manual::attach_protocols(channel::ptr channel)
 {
-    if (channel->negotiated_version() >= version::level::bip31)
+    const auto version = channel->negotiated_version();
+
+    if (version >= version::level::bip31)
         attach<protocol_ping_60001>(channel)->start();
     else
         attach<protocol_ping_31402>(channel)->start();
 
+    if (version >= message::version::level::bip61)
+        attach<protocol_reject_70002>(channel)->start();
+
     attach<protocol_address_31402>(channel)->start();
     attach<protocol_block_in>(channel, chain_)->start();
     attach<protocol_block_out>(channel, chain_)->start();

src/sessions/session_outbound.cpp

@@ -45,11 +45,16 @@ session_outbound::session_outbound(full_node& network, safe_chain& chain)
 
 void session_outbound::attach_protocols(channel::ptr channel)
 {
-    if (channel->negotiated_version() >= version::level::bip31)
+    const auto version = channel->negotiated_version();
+
+    if (version >= version::level::bip31)
         attach<protocol_ping_60001>(channel)->start();
     else
         attach<protocol_ping_31402>(channel)->start();
 
+    if (version >= message::version::level::bip61)
+        attach<protocol_reject_70002>(channel)->start();
+
     attach<protocol_address_31402>(channel)->start();
     attach<protocol_block_in>(channel, chain_)->start();
     attach<protocol_block_out>(channel, chain_)->start();