Merge pull request #218 from xloem/range-comparison

evoskuil · web-flow · commit 5c66b6f99cdb · 2020-10-23T20:02:52.000-05:00
resolve noop comparison warning
diff --git a/src/zmq/certificate.cpp b/src/zmq/certificate.cpp
@@ -79,7 +79,7 @@ bool certificate::create(config::sodium& out_public,
 {
     // Loop until neither key's base85 encoding includes the # character.
     // This ensures that the value can be used in libbitcoin settings files.
-    for (uint8_t attempt = 0; attempt <= max_uint8; attempt++)
+    for (uint8_t attempt = 0; attempt < max_uint8; attempt++)
     {
         char public_key[zmq_encoded_key_size + 1] = { 0 };
         char private_key[zmq_encoded_key_size + 1] = { 0 };

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ bool certificate::create(config::sodium& out_public,`
`79`	`79`	`{`
`80`	`80`	`// Loop until neither key's base85 encoding includes the # character.`
`81`	`81`	`// This ensures that the value can be used in libbitcoin settings files.`
`82`		`- for (uint8_t attempt = 0; attempt <= max_uint8; attempt++)`
	`82`	`+ for (uint8_t attempt = 0; attempt < max_uint8; attempt++)`
`83`	`83`	`{`
`84`	`84`	`char public_key[zmq_encoded_key_size + 1] = { 0 };`
`85`	`85`	`char private_key[zmq_encoded_key_size + 1] = { 0 };`