Add and parse electrum advertise_binds/safes.

Author: evoskuil

include/bitcoin/server/settings.hpp

@@ -97,14 +97,18 @@ class BCS_API settings
         /// Maximum cumulative number of address subscriptions per channel.
         uint32_t maximum_subscriptions{ 1'000'000 };
 
-        /// Arbitrary server name returned by server.version.
+        /// Arbitrary name returned by server.version and server.features.
         std::string server_name{ BC_USER_AGENT };
 
         /// Arbitrary string returned by server.donation_address.
         std::string donation_address{};
 
         /// Arbitrary string returned by server.banner.
         std::string banner_message{};
+
+        /// Advertised as self via server.features (limit one each per host).
+        network::config::endpoints advertise_binds{};
+        network::config::endpoints advertise_safes{};
     };
 
     /// html (http/s) document server settings (has directory/default).

src/parser.cpp

@@ -1154,6 +1154,16 @@ options_metadata parser::load_settings() THROWS
         value<std::string>(&configured.server.electrum.banner_message),
         "String returned by server.banner, defaults to empty."
     )
+    (
+        "electrum.advertise_bind",
+        value<network::config::endpoints>(&configured.server.electrum.advertise_binds),
+        "Advertised host:port at which this server can be reached (defaults to empty)."
+    )
+    (
+        "electrum.advertise_safe",
+        value<network::config::endpoints>(&configured.server.electrum.advertise_safes),
+        "Advertised secure host:port at which this server can be reached (defaults to empty)."
+    )
 
     /* [stratum_v1] */
     (

test/settings.cpp

@@ -237,6 +237,8 @@ BOOST_AUTO_TEST_CASE(server__electrum_server__defaults__expected)
     BOOST_REQUIRE_EQUAL(server.server_name, BC_USER_AGENT);
     BOOST_REQUIRE(server.donation_address.empty());
     BOOST_REQUIRE(server.banner_message.empty());
+    BOOST_REQUIRE(server.advertise_binds.empty());
+    BOOST_REQUIRE(server.advertise_safes.empty());
 }
 
 BOOST_AUTO_TEST_CASE(server__stratum_v1_server__defaults__expected)