Skip to content

Commit 8351ed6

Browse files
committed
Sent not impl for mempool_get_fee_histogram().
1 parent d0ea49f commit 8351ed6

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

src/protocols/electrum/protocol_electrum_mempool.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ void protocol_electrum::handle_mempool_get_fee_histogram(const code& ec,
4545
}
4646

4747
// TODO: Empty array (of tuples), could be simulated with block fees.
48-
send_result(array_t{}, 42, BIND(complete, _1));
48+
////send_result(array_t{}, 42, BIND(complete, _1));
49+
send_code(error::not_implemented);
4950
}
5051

5152
void protocol_electrum::handle_mempool_get_info(const code& ec,

test/protocols/electrum/electrum_mempool.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ BOOST_FIXTURE_TEST_SUITE(electrum_tests, electrum_setup_fixture)
2323

2424
using namespace system;
2525
static const code wrong_version{ server::error::wrong_version };
26+
static const code not_implemented{ server::error::not_implemented };
2627

2728
// mempool.get_fee_histogram
2829

@@ -51,12 +52,14 @@ BOOST_AUTO_TEST_CASE(electrum__mempool_get_fee_histogram__extra_param__dropped)
5152
REQUIRE_NO_THROW_TRUE(response.at("dropped").as_bool());
5253
}
5354

54-
BOOST_AUTO_TEST_CASE(electrum__mempool_get_fee_histogram__empty_params__empty_array)
55+
BOOST_AUTO_TEST_CASE(electrum__mempool_get_fee_histogram__empty_params__not_implemented)
5556
{
5657
BOOST_REQUIRE(handshake(electrum::version::v1_2));
5758

5859
const auto response = get(R"({"id":603,"method":"mempool.get_fee_histogram","params":[]})" "\n");
59-
REQUIRE_NO_THROW_TRUE(response.at("result").as_array().empty());
60+
REQUIRE_NO_THROW_TRUE(response.at("error").as_object().at("code").is_int64());
61+
BOOST_REQUIRE_EQUAL(response.at("error").as_object().at("code").as_int64(), not_implemented.value());
62+
///REQUIRE_NO_THROW_TRUE(response.at("result").as_array().empty());
6063
}
6164

6265
// mempool.get_info

0 commit comments

Comments
 (0)