Clear electrum midstate caching on reorganized, not regressed.

Author: evoskuil

include/bitcoin/server/protocols/protocol_electrum.hpp

@@ -242,7 +242,7 @@ class BCS_API protocol_electrum
     void do_header(node::header_t link) NOEXCEPT;
     void do_outpoint(node::header_t link) NOEXCEPT;
     void do_scripthash(node::header_t link) NOEXCEPT;
-    void do_regressed(node::header_t link) NOEXCEPT;
+    void do_reorganized(node::header_t link) NOEXCEPT;
 
     /// Address.
     /// -----------------------------------------------------------------------

src/protocols/electrum/protocol_electrum.cpp

@@ -169,12 +169,11 @@ bool protocol_electrum::handle_event(const code&, node::chase event_,
 
             break;
         }
-        case node::chase::regressed:
-        case node::chase::disorganized:
+        case node::chase::reorganized:
         {
             // value is regression branch_point.
             BC_ASSERT(std::holds_alternative<node::height_t>(value));
-            NOTIFY(do_regressed, std::get<node::height_t>(value));
+            NOTIFY(do_reorganized, std::get<node::height_t>(value));
             break;
         }
         default:

src/protocols/electrum/protocol_electrum_scripthash_subscribe.cpp

@@ -226,8 +226,8 @@ void protocol_electrum::scripthash_notify(const hash_digest& status,
 // regress
 // ----------------------------------------------------------------------------
 
-// The chain has regressed, clear all midstate cache and cursors.
-void protocol_electrum::do_regressed(node::header_t) NOEXCEPT
+// The chain has been reduced in height, clear all midstate cache and cursors.
+void protocol_electrum::do_reorganized(node::header_t) NOEXCEPT
 {
     BC_ASSERT(notification_strand_.running_in_this_thread());