Implement and test handle_blockchain_transaction_get.

Author: evoskuil

src/protocols/protocol_electrum.cpp

@@ -447,11 +447,40 @@ void protocol_electrum::handle_blockchain_transaction_broadcast(const code& ec,
 }
 
 void protocol_electrum::handle_blockchain_transaction_get(const code& ec,
-    rpc_interface::blockchain_transaction_get, const std::string& ,
-    bool ) NOEXCEPT
+    rpc_interface::blockchain_transaction_get, const std::string& tx_hash,
+    bool verbose) NOEXCEPT
 {
-    if (stopped(ec)) return;
-    send_code(error::not_implemented);
+    if (stopped(ec))
+        return;
+
+    // Changed in version 1.2: verbose argument added.
+    // Changed in version 1.1: ignored argument height removed.
+
+    hash_digest hash{};
+    if (!decode_hash(hash, tx_hash))
+    {
+        send_code(error::invalid_argument);
+        return;
+    }
+
+    const auto& query = archive();
+    const auto tx = query.get_transaction(query.to_tx(hash), true);
+    if (!tx)
+    {
+        send_code(error::not_found);
+        return;
+    }
+
+    const auto size = tx->serialized_size(true);
+    if (verbose)
+    {
+        // Verbose means whatever bitcoind returns for getrawtransaction, lolz.
+        send_result(value_from(bitcoind(*tx)), two * size, BIND(complete, _1));
+    }
+    else
+    {
+        send_result(to_hex(*tx, size, true), two * size, BIND(complete, _1));
+    }
 }
 
 void protocol_electrum::handle_blockchain_transaction_get_merkle(const code& ec,
@@ -486,7 +515,7 @@ void protocol_electrum::handle_server_banner(const code& ec,
     if (stopped(ec))
         return;
 
-    send_result({ options().banner_message }, 42, BIND(complete, _1));
+    send_result(options().banner_message, 42, BIND(complete, _1));
 }
 
 void protocol_electrum::handle_server_donation_address(const code& ec,
@@ -495,7 +524,7 @@ void protocol_electrum::handle_server_donation_address(const code& ec,
     if (stopped(ec))
         return;
 
-    send_result({ options().donation_address }, 42, BIND(complete, _1));
+    send_result(options().donation_address, 42, BIND(complete, _1));
 }
 
 void protocol_electrum::handle_server_features(const code& ec,
@@ -520,7 +549,7 @@ void protocol_electrum::handle_server_ping(const code& ec,
         return;
 
     // Any receive, including ping, resets the base channel inactivity timer.
-    send_result({ null_t{} }, 42, BIND(complete, _1));
+    send_result(null_t{}, 42, BIND(complete, _1));
 }
 
 // Handlers (mempool).

test/protocols/electrum/electrum_transactions.cpp

@@ -26,6 +26,8 @@ BOOST_FIXTURE_TEST_SUITE(electrum_tests, electrum_setup_fixture)
 // blockchain.transaction.broadcast
 
 using namespace system;
+static const code not_found{ server::error::not_found };
+static const code not_implemented{ server::error::not_implemented };
 static const code invalid_argument{ server::error::invalid_argument };
 static const code unconfirmable_transaction{ server::error::unconfirmable_transaction };
 
@@ -63,4 +65,79 @@ BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_broadcast__genesis_coinbas
     BOOST_CHECK_EQUAL(response.at("error").as_object().at("code").as_int64(), unconfirmable_transaction.value());
 }
 
+// blockchain.transaction.get
+
+BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__empty_hash__invalid_argument)
+{
+    BOOST_CHECK(handshake());
+
+    const auto response = get(R"({"id":77,"method":"blockchain.transaction.get","params":["",false]})" "\n");
+    BOOST_CHECK_EQUAL(response.at("error").as_object().at("code").as_int64(), invalid_argument.value());
+}
+
+BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__invalid_hash__invalid_argument)
+{
+    BOOST_CHECK(handshake());
+
+    const auto response = get(R"({"id":78,"method":"blockchain.transaction.get","params":["deadbeef",false]})" "\n");
+    BOOST_CHECK_EQUAL(response.at("error").as_object().at("code").as_int64(), invalid_argument.value());
+}
+
+BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__nonexistent_tx__not_found)
+{
+    BOOST_CHECK(handshake());
+
+    const auto bogus = "0000000000000000000000000000000000000000000000000000000000000042";
+    const auto request = R"({"id":79,"method":"blockchain.transaction.get","params":["%1%",false]})" "\n";
+    const auto response = get((boost::format(request) % bogus).str());
+    BOOST_CHECK_EQUAL(response.at("error").as_object().at("code").as_int64(), not_found.value());
+}
+
+BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__missing_param__dropped)
+{
+    BOOST_CHECK(handshake());
+
+    const auto& coinbase = *genesis.transactions_ptr()->front();
+    const auto tx_hash = encode_hash(coinbase.hash(false));
+    const auto request = R"({"id":80,"method":"blockchain.transaction.get","params":["%1%"]})" "\n";
+    const auto response = get((boost::format(request) % tx_hash).str());
+    BOOST_CHECK(response.at("dropped").as_bool());
+}
+
+BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__extra_param__dropped)
+{
+    BOOST_CHECK(handshake());
+
+    const auto& coinbase = *genesis.transactions_ptr()->front();
+    const auto tx_hash = encode_hash(coinbase.hash(false));
+    const auto request = R"({"id":81,"method":"blockchain.transaction.get","params":["%1%",false,"extra"]})" "\n";
+    const auto response = get((boost::format(request) % tx_hash).str());
+    BOOST_CHECK(response.at("dropped").as_bool());
+}
+
+BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__genesis_coinbase_verbose_false__expected)
+{
+    BOOST_CHECK(handshake());
+
+    const auto& coinbase = *genesis.transactions_ptr()->front();
+    const auto tx_hash = encode_hash(coinbase.hash(false));
+    const auto request = R"({"id":82,"method":"blockchain.transaction.get","params":["%1%",false]})" "\n";
+    const auto response = get((boost::format(request) % tx_hash).str());
+    BOOST_CHECK_EQUAL(response.at("result").as_string(), encode_base16(coinbase.to_data(true)));
+}
+
+BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__genesis_coinbase_verbose_true__expected)
+{
+    BOOST_CHECK(handshake());
+
+    const auto& coinbase = *genesis.transactions_ptr()->front();
+    const auto tx_hash = encode_hash(coinbase.hash(false));
+    const auto request = R"({"id":83,"method":"blockchain.transaction.get","params":["%1%",true]})" "\n";
+    const auto response = get((boost::format(request) % tx_hash).str());
+    BOOST_CHECK_EQUAL(response.at("result").as_object(), value_from(bitcoind(coinbase)));
+}
+
+// blockchain.transaction.get_merkle
+// blockchain.transaction.id_from_pos
+
 BOOST_AUTO_TEST_SUITE_END()