Add/test electrum blockchain.transaction.broadcast (partial).

Author: evoskuil

src/protocols/protocol_electrum.cpp

@@ -409,14 +409,41 @@ void protocol_electrum::handle_blockchain_scripthash_unsubscribe(const code& ec,
     send_code(error::not_implemented);
 }
 
-// TODO: requires tx pool in order to validate against unconfirmed txs.
-// TODO: requires that p2p channels subscribe to transaction broadcast.
 void protocol_electrum::handle_blockchain_transaction_broadcast(const code& ec,
     rpc_interface::blockchain_transaction_broadcast,
-    const std::string& ) NOEXCEPT
+    const std::string& raw_tx) NOEXCEPT
 {
-    if (stopped(ec)) return;
-    send_code(error::not_implemented);
+    if (stopped(ec))
+        return;
+
+    // ElectrumX changed in version 1.1 to return error vs. bitcoind result.
+    // Previously it returned text string (bitcoind message) in the error case.
+
+    data_chunk tx_data{};
+    if (!decode_base16(tx_data, raw_tx))
+    {
+        send_code(error::invalid_argument);
+        return;
+    }
+
+    const auto tx = to_shared<chain::transaction>(tx_data, true);
+    if (!tx->is_valid())
+    {
+        send_code(error::invalid_argument);
+        return;
+    }
+
+    // TODO: handle just as any peer annoucement, validate and relay.
+    // TODO: requires tx pool in order to validate against unconfirmed txs.
+    constexpr auto confirmable = false;
+    if (!confirmable)
+    {
+        send_code(error::unconfirmable_transaction);
+        return;
+    }
+
+    constexpr auto size = two * hash_size;
+    send_result(encode_base16(tx->hash(false)), size, BIND(complete, _1));
 }
 
 void protocol_electrum::handle_blockchain_transaction_get(const code& ec,

test/protocols/electrum/electrum_transactions.cpp

@@ -17,8 +17,50 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 #include "../../test.hpp"
+#include "../blocks.hpp"
 #include "electrum.hpp"
+#include <boost/format.hpp>
 
 BOOST_FIXTURE_TEST_SUITE(electrum_tests, electrum_setup_fixture)
 
+// blockchain.transaction.broadcast
+
+using namespace system;
+static const code invalid_argument{ server::error::invalid_argument };
+static const code unconfirmable_transaction{ server::error::unconfirmable_transaction };
+
+BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_broadcast__empty__invalid_argument)
+{
+    BOOST_CHECK(handshake());
+
+    const auto response = get(R"({"id":74,"method":"blockchain.transaction.broadcast","params":[""]})" "\n");
+    BOOST_CHECK_EQUAL(response.at("error").as_object().at("code").as_int64(), invalid_argument.value());
+}
+
+BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_broadcast__invalid_encoding__invalid_argument)
+{
+    BOOST_CHECK(handshake());
+
+    const auto response = get(R"({"id":75,"method":"blockchain.transaction.broadcast","params":["deadbeef"]})" "\n");
+    BOOST_CHECK_EQUAL(response.at("error").as_object().at("code").as_int64(), invalid_argument.value());
+}
+
+BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_broadcast__invalid_tx__invalid_argument)
+{
+    BOOST_CHECK(handshake());
+
+    const auto response = get(R"({"id":76,"method":"blockchain.transaction.broadcast","params":["0100000001"]})" "\n");
+    BOOST_CHECK_EQUAL(response.at("error").as_object().at("code").as_int64(), invalid_argument.value());
+}
+
+BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_broadcast__genesis_coinbase__unconfirmable_transaction)
+{
+    BOOST_CHECK(handshake());
+
+    const auto tx0_text = encode_base16(genesis.transactions_ptr()->front()->to_data(true));
+    constexpr auto request = R"({"id":73,"method":"blockchain.transaction.broadcast","params":["%1%"]})" "\n";
+    const auto response = get((boost::format(request) % tx0_text).str());
+    BOOST_CHECK_EQUAL(response.at("error").as_object().at("code").as_int64(), unconfirmable_transaction.value());
+}
+
 BOOST_AUTO_TEST_SUITE_END()