From b0c6cd272895db5f7633c7211f1e9ba91fe7c64d Mon Sep 17 00:00:00 2001 From: Thomas Eizinger Date: Sun, 15 May 2022 21:45:35 +1000 Subject: [PATCH 1/2] Remove deprecated function --- core/CHANGELOG.md | 1 + core/src/muxing.rs | 11 ----------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md index 3a2cffea52a..83147854c4f 100644 --- a/core/CHANGELOG.md +++ b/core/CHANGELOG.md @@ -1,6 +1,7 @@ # 0.33.0 [unreleased] - Have methods on `Transport` take `&mut self` instead of `self`. See [PR 2529]. +- Remove deprecated function `StreamMuxer::is_remote_acknowledged` [PR 2529]: https://github.com/libp2p/rust-libp2p/pull/2529 diff --git a/core/src/muxing.rs b/core/src/muxing.rs index 12beb51d9dd..7285cef7c5a 100644 --- a/core/src/muxing.rs +++ b/core/src/muxing.rs @@ -203,17 +203,6 @@ pub trait StreamMuxer { /// Destroys a substream. fn destroy_substream(&self, s: Self::Substream); - /// Returns `true` if the remote has shown any sign of activity after the muxer has been open. - /// - /// For optimisation purposes, the connection handshake of libp2p can be very optimistic and is - /// allowed to assume that the handshake has succeeded when it didn't in fact succeed. This - /// method can be called in order to determine whether the remote has accepted our handshake or - /// has potentially not received it yet. - #[deprecated(note = "This method is unused and will be removed in the future")] - fn is_remote_acknowledged(&self) -> bool { - true - } - /// Closes this `StreamMuxer`. /// /// After this has returned `Poll::Ready(Ok(()))`, the muxer has become useless. All From 279925e1926c61f9268c102818036cdfb5d5e043 Mon Sep 17 00:00:00 2001 From: Max Inden Date: Mon, 23 May 2022 16:27:27 +0200 Subject: [PATCH 2/2] Update core/CHANGELOG.md --- core/CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md index 83147854c4f..09aaef501bc 100644 --- a/core/CHANGELOG.md +++ b/core/CHANGELOG.md @@ -1,9 +1,10 @@ # 0.33.0 [unreleased] - Have methods on `Transport` take `&mut self` instead of `self`. See [PR 2529]. -- Remove deprecated function `StreamMuxer::is_remote_acknowledged` +- Remove deprecated function `StreamMuxer::is_remote_acknowledged`. See [PR 2665]. [PR 2529]: https://github.com/libp2p/rust-libp2p/pull/2529 +[PR 2665]: https://github.com/libp2p/rust-libp2p/pull/2665 # 0.32.1