feat: clean JSON impl

Author: shad0wshayd3

include/REX/REX/JSON.h

@@ -30,9 +30,14 @@ namespace REX::JSON
 	{
 	public:
 		Setting(path_t a_path, T a_default) :
-			TSetting<T, Store>(a_default),
-			m_path(a_path)
-		{}
+			TSetting<T, Store>(a_default)
+		{
+			if (a_path[0] != '/') {
+				m_path = std::format("/{}"sv, a_path);
+			} else {
+				m_path = std::move(a_path);
+			}
+		}
 
 	public:
 		virtual void Load(void* a_data, bool a_isBase) override

src/REX/REX/JSON.cpp

@@ -17,17 +17,7 @@ namespace REX::JSON
 			T&     a_valueDefault)
 		{
 			const auto& json = *static_cast<glz::json_t*>(a_data);
-			if (a_path[0] == '/') {
-				a_value = glz::get<T>(json, a_path).value_or(a_valueDefault);
-			} else {
-				auto path = std::format("/{}"sv, a_path);
-				REX::DEBUG("reading from {}", path);
-				auto value = glz::get<T>(json, path);
-				REX::DEBUG("found: {}", value.has_value());
-				REX::DEBUG("test output1: {}", value->get());
-				REX::DEBUG("test output2: {}", value.value_or(a_valueDefault).get());
-				a_value = value.value_or(a_valueDefault);
-			}
+			a_value = glz::get<T>(json, a_path).value_or(a_valueDefault);
 		}
 
 		template void SettingLoad<bool>(void*, path_t, bool&, bool&);
@@ -48,12 +38,7 @@ namespace REX::JSON
 			T&     a_value)
 		{
 			auto& json = *static_cast<glz::json_t*>(a_data);
-			if (a_path[0] == '/') {
-				glz::set(json, a_path, a_value);
-			} else {
-				auto path = std::format("/{}"sv, a_path);
-				glz::set(json, path, a_value);
-			}
+			glz::set(json, a_path, a_value);
 		}
 
 		template void SettingSave<bool>(void*, path_t, bool&);
@@ -72,11 +57,7 @@ namespace REX::JSON
 	{
 		if (std::filesystem::exists(m_fileBase)) {
 			glz::json_t result;
-			std::string buffer;
-			const auto  errorc = glz::read_file_json(result, m_fileBase, buffer);
-			if (errorc) {
-				REX::ERROR("{}"sv, glz::format_error(errorc, buffer));
-			} else {
+			if (!glz::read_file_json(result, m_fileBase, std::string{})) {
 				for (auto setting : m_settings) {
 					setting->Load(&result, true);
 				}
@@ -85,11 +66,7 @@ namespace REX::JSON
 
 		if (std::filesystem::exists(m_fileUser)) {
 			glz::json_t result;
-			std::string buffer;
-			const auto  errorc = glz::read_file_json(result, m_fileUser, buffer);
-			if (errorc) {
-				REX::ERROR("{}"sv, glz::format_error(errorc, buffer));
-			} else {
+			if (!glz::read_file_json(result, m_fileUser, std::string{})) {
 				for (auto setting : m_settings) {
 					setting->Load(&result, true);
 				}
@@ -101,22 +78,14 @@ namespace REX::JSON
 	{
 		glz::json_t output;
 		if (std::filesystem::exists(m_fileBase)) {
-			std::string buffer;
-			const auto  errorc = glz::read_file_json(output, m_fileBase, buffer);
-			if (errorc) {
-				REX::ERROR("{}"sv, glz::format_error(errorc, buffer));
-			}
+			(void)glz::read_file_json(output, m_fileBase, std::string{});
 		}
 
 		for (auto& setting : m_settings) {
 			setting->Save(&output);
 		}
 
-		std::string buffer;
-		const auto  errorc = glz::write_file_json(output, m_fileBase, buffer);
-		if (errorc) {
-			REX::ERROR("{}"sv, glz::format_error(errorc, buffer));
-		}
+		(void)glz::write_file_json(output, m_fileBase, std::string{});
 	}
 }
 #endif