fix: clang-cl issues

Author: qudix

include/REL/HookObject.h

@@ -30,6 +30,7 @@ namespace REL
 		HookObject(const std::uintptr_t a_address, const HOOK_TYPE a_type);
 		HookObject(const std::uintptr_t a_address, const HOOK_TYPE a_type, const HOOK_STEP a_step);
 		HookObject(const std::uintptr_t a_address, const HOOK_STEP a_step);
+		HookObject(const std::uintptr_t a_address, const char* a_name, const HOOK_STEP a_step);
 		HookObject(const std::uintptr_t a_address, const char* a_name, const HOOK_TYPE a_type);
 		HookObject(const std::uintptr_t a_address, const char* a_name, const HOOK_TYPE a_type, const HOOK_STEP a_step);
 

include/REL/Relocation.h

@@ -157,7 +157,7 @@ namespace REL
 			noexcept(std::is_nothrow_invocable_v<F, First, Rest...>)
 		{
 			using result_t = std::invoke_result_t<F, First, Rest...>;
-			std::aligned_storage_t<sizeof(result_t), alignof(result_t)> result;
+			alignas(result_t) std::array<std::byte, sizeof(result_t)> result;
 
 			using func_t = member_function_non_pod_type_t<F>;
 			auto func = REX::UNRESTRICTED_CAST<func_t*>(std::forward<F>(a_func));

src/REL/HookObject.cpp

@@ -1,5 +1,4 @@
-#pragma once
-
+#include "REL/HookObject.h"
 #include "REL/HookStore.h"
 
 namespace REL
@@ -38,6 +37,12 @@ namespace REL
 		m_name = std::to_string(m_handle);
 	}
 
+	HookObject::HookObject(const std::uintptr_t a_address, const char* a_name, const HOOK_STEP a_step) :
+		m_address(a_address), m_name(a_name), m_step(a_step)
+	{
+		m_handle = HookStore::GetSingleton()->Add(this);
+	}
+
 	HookObject::HookObject(const std::uintptr_t a_address, const char* a_name, const HOOK_TYPE a_type) :
 		m_address(a_address), m_name(a_name), m_type(a_type)
 	{

src/REX/REX/LOG.cpp

@@ -60,7 +60,7 @@ namespace REX
 
 namespace REX::IMPL
 {
-	[[noreturn]] void FAIL(const std::source_location a_loc, const std::string_view a_fmt)
+	void FAIL(const std::source_location a_loc, const std::string_view a_fmt)
 	{
 		const auto body = [&]() {
 			constexpr std::array directories{
@@ -116,7 +116,7 @@ namespace REX::IMPL
 		REX::W32::TerminateProcess(REX::W32::GetCurrentProcess(), 1);
 	}
 
-	[[noreturn]] void FAIL(const std::source_location a_loc, const std::wstring_view a_fmt)
+	void FAIL(const std::source_location a_loc, const std::wstring_view a_fmt)
 	{
 		const auto body = [&]() {
 			constexpr std::array directories{

xmake.lua

@@ -105,4 +105,27 @@ target("commonlib-shared", function()
         "cl::/we4715", -- not all control paths return a value
         { public = true }
     )
+
+    -- add flags (clang-cl)
+    add_cxxflags(
+        "clang_cl::-fms-compatibility",
+        "clang_cl::-fms-extensions",
+        { public = true }
+    )
+
+    -- add flags (clang-cl: disable warnings)
+    add_cxxflags(
+        "clang_cl::-Wno-delete-non-abstract-non-virtual-dtor",
+        "clang_cl::-Wno-deprecated-volatile",
+        "clang_cl::-Wno-ignored-qualifiers",
+        "clang_cl::-Wno-inconsistent-missing-override",
+        "clang_cl::-Wno-invalid-offsetof",
+        "clang_cl::-Wno-microsoft-include",
+        "clang_cl::-Wno-overloaded-virtual",
+        "clang_cl::-Wno-pragma-system-header-outside-header",
+        "clang_cl::-Wno-reinterpret-base-class",
+        "clang_cl::-Wno-switch",
+        "clang_cl::-Wno-unused-private-field",
+        { public = true }
+    )
 end)