Skip to content

Commit f078c92

Browse files
committed
Use uv run with dev dependency for Python CI tests
Add `requests` as an optional dev dependency in pyproject.toml and switch the CI workflow to use `uv run --extra dev` instead of manually installing packages via `uv pip install --system`. Co-Authored-By: HAL 9000
1 parent fb4756f commit f078c92

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/python.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ jobs:
2626
- name: Start bitcoind and electrs
2727
run: docker compose up -d
2828

29-
- name: Install testing prerequisites
30-
run: uv pip install --system requests
31-
3229
- name: Run Python unit tests
3330
env:
3431
BITCOIN_CLI_BIN: "docker exec ldk-node-bitcoin-1 bitcoin-cli"
@@ -37,4 +34,4 @@ jobs:
3734
ESPLORA_ENDPOINT: "http://127.0.0.1:3002"
3835
run: |
3936
cd $LDK_NODE_PYTHON_DIR
40-
python3 -m unittest discover -s src/ldk_node
37+
uv run --group dev python -m unittest discover -s src/ldk_node

bindings/python/pyproject.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ classifiers = [
2424
"Github" = "https://github.com/lightningdevkit/ldk-node"
2525
"Bug Tracker" = "https://github.com/lightningdevkit/ldk-node/issues"
2626

27+
[dependency-groups]
28+
dev = ["requests"]
29+
2730
[tool.hatch.build.targets.wheel]
2831
packages = ["src/ldk_node"]
2932

0 commit comments

Comments
 (0)