Make fuzz targets deterministic

Use deterministic time and hash table ordering when building with
cfg(fuzzing) to ensure fuzz test cases reproduce consistently.

In channelmanager, use highest_seen_timestamp instead of
SystemTime::now() under cfg(fuzzing) for duration_since_epoch and
stale payment removal.

In offers/flow, apply the same cfg(fuzzing) treatment to
duration_since_epoch so offers-related code paths also use
highest_seen_timestamp.

In channel, disable hold time tracking under cfg(fuzzing) by
returning None from duration_since_epoch, consistent with the
no-std behavior.

In hash_tables, extend the existing test deterministic hasher to
also apply under cfg(fuzzing), always using zeroed SipHash keys.

AI tools were used in preparing this commit.

Author: joostjager

lightning/src/ln/channel.rs

@@ -16717,10 +16717,10 @@ impl<'a, 'b, 'c, ES: EntropySource, SP: SignerProvider>
 }
 
 fn duration_since_epoch() -> Option<Duration> {
-	#[cfg(not(feature = "std"))]
+	#[cfg(any(not(feature = "std"), fuzzing))]
 	let now = None;
 
-	#[cfg(feature = "std")]
+	#[cfg(all(feature = "std", not(fuzzing)))]
 	let now = Some(
 		std::time::SystemTime::now()
 			.duration_since(std::time::SystemTime::UNIX_EPOCH)

lightning/src/ln/channelmanager.rs

@@ -8936,11 +8936,11 @@ impl<
 				let _ = self.handle_error(err, counterparty_node_id);
 			}
 
-			#[cfg(feature = "std")]
+			#[cfg(all(feature = "std", not(fuzzing)))]
 			let duration_since_epoch = std::time::SystemTime::now()
 				.duration_since(std::time::SystemTime::UNIX_EPOCH)
 				.expect("SystemTime::now() should come after SystemTime::UNIX_EPOCH");
-			#[cfg(not(feature = "std"))]
+			#[cfg(any(not(feature = "std"), fuzzing))]
 			let duration_since_epoch = Duration::from_secs(
 				self.highest_seen_timestamp.load(Ordering::Acquire).saturating_sub(7200) as u64,
 			);
@@ -14129,7 +14129,7 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
 		let currency =
 			Network::from_chain_hash(self.chain_hash).map(Into::into).unwrap_or(Currency::Bitcoin);
 
-		#[cfg(feature = "std")]
+		#[cfg(all(feature = "std", not(fuzzing)))]
 		let duration_since_epoch = {
 			use std::time::SystemTime;
 			SystemTime::now().duration_since(SystemTime::UNIX_EPOCH)
@@ -14139,7 +14139,7 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
 		// This may be up to 2 hours in the future because of bitcoin's block time rule or about
 		// 10-30 minutes in the past if a block hasn't been found recently. This should be fine as
 		// the default invoice expiration is 2 hours, though shorter expirations may be problematic.
-		#[cfg(not(feature = "std"))]
+		#[cfg(any(not(feature = "std"), fuzzing))]
 		let duration_since_epoch =
 			Duration::from_secs(self.highest_seen_timestamp.load(Ordering::Acquire) as u64);
 
@@ -14996,9 +14996,9 @@ impl<
 	}
 
 	pub(super) fn duration_since_epoch(&self) -> Duration {
-		#[cfg(not(feature = "std"))]
+		#[cfg(any(not(feature = "std"), fuzzing))]
 		let now = Duration::from_secs(self.highest_seen_timestamp.load(Ordering::Acquire) as u64);
-		#[cfg(feature = "std")]
+		#[cfg(all(feature = "std", not(fuzzing)))]
 		let now = std::time::SystemTime::now()
 			.duration_since(std::time::SystemTime::UNIX_EPOCH)
 			.expect("SystemTime::now() should come after SystemTime::UNIX_EPOCH");

lightning/src/offers/flow.rs

@@ -183,9 +183,9 @@ impl<MR: MessageRouter, L: Logger> OffersMessageFlow<MR, L> {
 	}
 
 	fn duration_since_epoch(&self) -> Duration {
-		#[cfg(not(feature = "std"))]
+		#[cfg(any(not(feature = "std"), fuzzing))]
 		let now = Duration::from_secs(self.highest_seen_timestamp.load(Ordering::Acquire) as u64);
-		#[cfg(feature = "std")]
+		#[cfg(all(feature = "std", not(fuzzing)))]
 		let now = std::time::SystemTime::now()
 			.duration_since(std::time::SystemTime::UNIX_EPOCH)
 			.expect("SystemTime::now() should come after SystemTime::UNIX_EPOCH");

lightning/src/util/hash_tables.rs

@@ -6,11 +6,11 @@
 pub use hashbrown::hash_map;
 
 mod hashbrown_tables {
-	#[cfg(all(feature = "std", not(test)))]
+	#[cfg(all(feature = "std", not(test), not(fuzzing)))]
 	mod hasher {
 		pub use std::collections::hash_map::RandomState;
 	}
-	#[cfg(all(feature = "std", test))]
+	#[cfg(all(feature = "std", any(test, fuzzing)))]
 	mod hasher {
 		#![allow(deprecated)] // hash::SipHasher was deprecated in favor of something only in std.
 		use core::hash::{BuildHasher, Hasher};
@@ -27,7 +27,10 @@ mod hashbrown_tables {
 
 		impl RandomState {
 			pub fn new() -> RandomState {
-				if std::env::var("LDK_TEST_DETERMINISTIC_HASHES").map(|v| v == "1").unwrap_or(false)
+				if cfg!(fuzzing)
+					|| std::env::var("LDK_TEST_DETERMINISTIC_HASHES")
+						.map(|v| v == "1")
+						.unwrap_or(false)
 				{
 					RandomState::Deterministic
 				} else {