Skip to content

Commit 2a8fdc9

Browse files
joostjagerclaude
andcommitted
Use consistent unwrap_or_else pattern for optional TLV fields
Initialize pending_claiming_payments and monitor_update_blocked_actions_per_peer with None and resolve with unwrap_or_else, matching the pattern used for other optional hash map fields like pending_intercepted_htlcs_legacy. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent c4a38ea commit 2a8fdc9

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

lightning/src/ln/channelmanager.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17398,9 +17398,9 @@ impl<'a, ES: EntropySource, SP: SignerProvider, L: Logger>
1739817398
let mut probing_cookie_secret: Option<[u8; 32]> = None;
1739917399
let mut claimable_htlc_purposes = None;
1740017400
let mut claimable_htlc_onion_fields = None;
17401-
let mut pending_claiming_payments = Some(new_hash_map());
17401+
let mut pending_claiming_payments = None;
1740217402
let mut monitor_update_blocked_actions_per_peer: Option<Vec<(_, BTreeMap<_, Vec<_>>)>> =
17403-
Some(Vec::new());
17403+
None;
1740417404
let mut events_override = None;
1740517405
let mut legacy_in_flight_monitor_updates: Option<
1740617406
HashMap<(PublicKey, OutPoint), Vec<ChannelMonitorUpdate>>,
@@ -17494,12 +17494,10 @@ impl<'a, ES: EntropySource, SP: SignerProvider, L: Logger>
1749417494
pending_intercepted_htlcs_legacy: pending_intercepted_htlcs_legacy
1749517495
.unwrap_or_else(new_hash_map),
1749617496
pending_outbound_payments,
17497-
// unwrap safety: pending_claiming_payments is guaranteed to be `Some` after read_tlv_fields
17498-
pending_claiming_payments: pending_claiming_payments.unwrap(),
17497+
pending_claiming_payments: pending_claiming_payments.unwrap_or_else(new_hash_map),
1749917498
received_network_pubkey,
17500-
// unwrap safety: monitor_update_blocked_actions_per_peer is guaranteed to be `Some` after read_tlv_fields
1750117499
monitor_update_blocked_actions_per_peer: monitor_update_blocked_actions_per_peer
17502-
.unwrap(),
17500+
.unwrap_or_else(Vec::new),
1750317501
fake_scid_rand_bytes,
1750417502
claimable_htlc_purposes,
1750517503
probing_cookie_secret,

0 commit comments

Comments
 (0)