Propagate closest-tag lookup errors

Author: linkdata

internal/gitsemver/gitsemver.go

@@ -141,7 +141,7 @@ func (vs *GitSemVer) GetTag(repo string) (tag string, match bool, err error) {
 			}
 		}
 		var closeToHEAD string
-		if closeToHEAD, _ = vs.Git.GetClosestTag(repo, "HEAD"); closeToHEAD != "" {
+		if closeToHEAD, err = vs.Git.GetClosestTag(repo, "HEAD"); err == nil && closeToHEAD != "" {
 			var found GitTag
 			if found, err = vs.getTreeHash(repo, closeToHEAD); err == nil {
 				for _, gt := range vs.tags {

internal/gitsemver/gitsemver_test.go

@@ -2,6 +2,7 @@ package gitsemver_test
 
 import (
 	"bytes"
+	"errors"
 	"testing"
 
 	gitsemver "github.com/linkdata/gitsemver/internal/gitsemver"
@@ -129,6 +130,18 @@ func Test_VersionStringer_GetTag(t *testing.T) {
 	isEqual(t, err, nil)
 }
 
+func Test_VersionStringer_GetTag_PropagatesClosestTagError(t *testing.T) {
+	env := MockEnvironment{}
+	expectedErr := errors.New("closest tag lookup failed")
+	git := &MockGitter{closestTagErr: expectedErr}
+	vs := gitsemver.GitSemVer{Git: git, Env: env}
+
+	_, _, err := vs.GetTag(".")
+	if !errors.Is(err, expectedErr) {
+		t.Fatalf("expected closest tag error, got %v", err)
+	}
+}
+
 func Test_VersionStringer_GetBranch(t *testing.T) {
 	env := MockEnvironment{}
 	git := &MockGitter{}

internal/gitsemver/mockgitter_test.go

@@ -29,10 +29,11 @@ var mockHistory = []gitsemver.GitTag{
 }
 
 type MockGitter struct {
-	branch   string
-	treehash string
-	TopTag   string
-	dirty    bool
+	branch        string
+	treehash      string
+	TopTag        string
+	dirty         bool
+	closestTagErr error
 }
 
 func (mg *MockGitter) Exec(args ...string) (output []byte, err error) {
@@ -83,6 +84,9 @@ func (mg *MockGitter) GetHashes(repo, tag string) (commit, tree string, err erro
 }
 
 func (mg *MockGitter) GetClosestTag(repo, from string) (tag string, err error) {
+	if mg.closestTagErr != nil {
+		return "", mg.closestTagErr
+	}
 	if repo == "." {
 		if from == "HEAD" {
 			from = mg.treehash