Skip to content

Commit a2ab8d8

Browse files
authored
Explicitly set default value to "UNFINISHED" for TraceBuilder's ResultType (#349)
1 parent f6ab57d commit a2ab8d8

4 files changed

Lines changed: 7 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
v5.1.19
2+
------
3+
* Explicitly set default value for TraceBuilder's ResultType to UNFINISHED to prevent null argument when building the trace in TraceBuilder.
4+
15
v5.1.18
26
------
37
* Minor UI updates to trace visualizer to refresh JavaScript dependencies.

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
version=5.1.18
1+
version=5.1.19
22
group=com.linkedin.parseq
33
org.gradle.parallel=true

subprojects/parseq-lambda-names/src/main/java/com/linkedin/parseq/lambda/SourcePointer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ private SourcePointer(String className, String methodName, Integer lineNumber) {
2222
.findFirst()
2323
.map(SourcePointer::sourcePointer);
2424
if (!ret.isPresent()) {
25-
System.out.println("WARNING ParSeq cannot generate lambda function SourcePointer"
25+
System.out.println("WARNING: ParSeq cannot generate lambda function SourcePointer."
2626
+ "source stacktrace will be printed:");
2727
exception.printStackTrace();
2828
}

subprojects/parseq/src/main/java/com/linkedin/parseq/trace/ShallowTraceBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public class ShallowTraceBuilder {
3838
private volatile String _name;
3939
private volatile boolean _hidden;
4040
private volatile String _value;
41-
private volatile ResultType _resultType;
41+
private volatile ResultType _resultType = ResultType.UNFINISHED;
4242
private volatile long _startNanos = -1;
4343
private volatile long _pendingNanos = -1;
4444
private volatile long _endNanos = -1;

0 commit comments

Comments
 (0)