Create test for: premium_40gb & error msgs

Author: mawilk90

tests/integration/conftest.py

@@ -11,7 +11,7 @@
 from itertools import count
 from pathlib import Path
 from random import randint
-from typing import Callable, Optional
+from typing import Callable, List, Optional
 
 import pytest
 import requests
@@ -203,7 +203,7 @@ def _generate_test_files(
     return _generate_test_files
 
 
-def create_vpc_w_subnet():
+def create_vpc_w_subnet(valid_regions: List[str] = None):
     """
     Creates and returns a VPC and a corresponding subnet.
 
@@ -214,7 +214,10 @@ def create_vpc_w_subnet():
     See: https://github.com/pytest-dev/pytest/issues/1216
     """
 
-    region = get_random_region_with_caps(required_capabilities=["VPCs", "NodeBalancers"])
+    region = get_random_region_with_caps(
+        required_capabilities=["VPCs", "NodeBalancers"],
+        valid_regions=valid_regions,
+    )
     vpc_label = get_random_text(5) + "label"
     subnet_label = get_random_text(5) + "label"
 

tests/integration/helpers.py

@@ -189,7 +189,9 @@ def retry_exec_test_command_with_delay(
 
 
 def get_random_region_with_caps(
-    required_capabilities: List[str], site_type="core"
+    required_capabilities: List[str],
+    site_type: str = "core",
+    valid_regions: List[str] = None,
 ):
     json_regions_data = exec_test_command(
         ["linode-cli", "regions", "ls", "--json"]
@@ -208,6 +210,10 @@ def get_random_region_with_caps(
     # Extract the region ids
     matching_region_ids = [region["id"] for region in matching_regions]
 
+    # To filter out regions that cannot be used for the Linode resource
+    if valid_regions:
+        matching_region_ids = [reg for reg in matching_region_ids if reg in valid_regions]
+
     return random.choice(matching_region_ids) if matching_region_ids else None
 
 

tests/integration/nodebalancers/conftest.py

@@ -1,3 +1,5 @@
+import json
+
 import pytest
 
 from tests.integration.conftest import create_vpc_w_subnet
@@ -6,6 +8,8 @@
     check_attribute_value,
     delete_target_id,
     exec_test_command,
+    get_random_region_with_caps,
+    get_random_text,
     wait_for_condition,
 )
 from tests.integration.linodes.helpers import DEFAULT_TEST_IMAGE
@@ -340,8 +344,9 @@ def simple_nodebalancer_with_config(linode_cloud_firewall):
 
 
 @pytest.fixture
-def get_vpc_with_subnet():
-    vpc_json = create_vpc_w_subnet()
+def get_vpc_with_subnet(request):
+    premium_regions = getattr(request, "param", None)
+    vpc_json = create_vpc_w_subnet(premium_regions)
 
     yield vpc_json
 

tests/integration/nodebalancers/test_node_balancers.py

@@ -13,6 +13,30 @@
 )
 
 
+# Lists of valid regions where NodeBalancers of type "premium" or "premium_40gb" can be created
+PREMIUM_REGIONS = [
+    "nl-ams",
+    "jp-tyo-3",
+    "sg-sin-2",
+    "de-fra-2",
+    "in-bom-2",
+    "gb-lon",
+    "us-lax",
+    "id-cgk",
+    "us-mia",
+    "it-mil",
+    "jp-osa",
+    "in-maa",
+    "se-sto",
+    "br-gru",
+    "us-sea",
+    "fr-par",
+    "us-iad",
+    "pl-labkrk-2",  # DevCloud
+]
+PREMIUM_40GB_REGIONS = ["us-iad"]  # No DevCloud region for premium_40gb type
+
+
 def nodebalancer_created():
     return "[0-9]+,balancer[0-9]+,us-ord,[0-9]+-[0-9]+-[0-9]+-[0-9]+.ip.linodeusercontent.com,0"
 
@@ -595,6 +619,7 @@ def test_nb_with_backend_vpc_only(get_vpc_with_subnet):
     delete_target_id(target="nodebalancers", id=nb_id)
 
 
+@pytest.mark.parametrize("get_vpc_with_subnet", [PREMIUM_REGIONS], indirect=True)
 def test_nb_with_frontend_ipv4_only(get_vpc_with_subnet):
     vpc = get_vpc_with_subnet
     ipv4_address = "10.0.0.2"  # first available address
@@ -637,3 +662,68 @@ def test_nb_with_frontend_ipv4_only(get_vpc_with_subnet):
     # assert len(nb_backend_vpcs) == 0
 
     delete_target_id(target="nodebalancers", id=nb_id)
+
+
+@pytest.mark.parametrize("get_vpc_with_subnet", [PREMIUM_REGIONS], indirect=True)
+def test_nb_with_frontend_ipv6_in_single_stack_vpc_fail(get_vpc_with_subnet):
+    vpc = get_vpc_with_subnet
+
+    result = exec_failing_test_command(
+        BASE_CMDS["nodebalancers"]
+        + [
+            "create",
+            "--region",
+            vpc["region"],
+            "--frontend_vpcs.subnet_id",
+            str(vpc["subnets"][0]["id"]),
+            "--frontend_vpcs.ipv6_range",
+            "/62",
+            "--type",
+            "premium",
+        ],
+    )
+    assert "Request failed: 400" in result
+    assert "No IPv6 subnets available in VPC" in result
+
+
+@pytest.mark.parametrize("get_vpc_with_subnet", [PREMIUM_REGIONS], indirect=True)
+def test_nb_with_frontend_and_default_type_fail(get_vpc_with_subnet):
+    vpc = get_vpc_with_subnet
+
+    result = exec_failing_test_command(
+        BASE_CMDS["nodebalancers"]
+        + [
+            "create",
+            "--region",
+            vpc["region"],
+            "--frontend_vpcs.subnet_id",
+            str(vpc["subnets"][0]["id"]),
+        ],
+    )
+    assert "Request failed: 400" in result
+    assert "NodeBalancer with frontend VPC IP must be premium" in result
+
+
+@pytest.mark.parametrize(
+    "get_vpc_with_subnet",
+    [PREMIUM_40GB_REGIONS],
+    indirect=True,
+)
+def test_nb_with_premium40gb_type(get_vpc_with_subnet):
+    vpc = get_vpc_with_subnet
+
+    nb_attrs = exec_test_command(
+        BASE_CMDS["nodebalancers"]
+        + [
+            "create",
+            "--region",
+            vpc["region"],
+            "--type",
+            "premium_40gb",
+            "--json",
+        ],
+    )
+    nb_attrs = json.loads(nb_attrs)
+    assert nb_attrs[0]["type"] == "premium_40gb"
+
+    delete_target_id(target="nodebalancers", id=str(nb_attrs[0]["id"]))