fix: Always load object values when converting MappedObjects to dict (#400)

* Always load object values when converting MappedObjects to dict

* Prevent overriding identifier attributes during construction

* make format

* Update unit test to cover parent_id issue

Author: lgarber-akamai

linode_api4/objects/base.py

@@ -1,5 +1,6 @@
 import time
 from datetime import datetime, timedelta
+from typing import Any, Dict, Optional
 
 from linode_api4.objects.serializable import JSONObject
 
@@ -99,6 +100,18 @@ def _expand_vals(self, target, **vals):
     def __repr__(self):
         return "Mapping containing {}".format(vars(self).keys())
 
+    @staticmethod
+    def _flatten_base_subclass(obj: "Base") -> Optional[Dict[str, Any]]:
+        if obj is None:
+            return None
+
+        # If the object hasn't already been lazy-loaded,
+        # manually refresh it
+        if not getattr(obj, "_populated", False):
+            obj._api_get()
+
+        return obj._raw_json
+
     @property
     def dict(self):
         result = vars(self).copy()
@@ -112,12 +125,17 @@ def dict(self):
                     (
                         item.dict
                         if isinstance(item, cls)
-                        else item._raw_json if isinstance(item, Base) else item
+                        else (
+                            self._flatten_base_subclass(item)
+                            if isinstance(item, Base)
+                            else item
+                        )
                     )
                     for item in v
                 ]
             elif isinstance(v, Base):
-                result[k] = v._raw_json
+                result[k] = self._flatten_base_subclass(v)
+
         return result
 
 
@@ -140,7 +158,10 @@ def __init__(self, client: object, id: object, json: object = {}) -> object:
         #: be updated on access.
         self._set("_raw_json", None)
 
-        for k in type(self).properties:
+        for k, v in type(self).properties.items():
+            if v.identifier:
+                continue
+
             self._set(k, None)
 
         self._set("id", id)

linode_api4/objects/dbase.py

@@ -12,10 +12,10 @@ class DerivedBase(Base):
     parent_id_name = "parent_id"  # override in child classes
 
     def __init__(self, client, id, parent_id, json={}):
-        Base.__init__(self, client, id, json=json)
-
         self._set(type(self).parent_id_name, parent_id)
 
+        Base.__init__(self, client, id, json=json)
+
     @classmethod
     def _api_get_derived(cls, parent, client):
         base_url = "{}/{}".format(

linode_api4/objects/object_storage.py

@@ -31,10 +31,10 @@ class ObjectStorageBucket(DerivedBase):
     id_attribute = "label"
 
     properties = {
-        "cluster": Property(),
+        "cluster": Property(identifier=True),
         "created": Property(is_datetime=True),
         "hostname": Property(),
-        "label": Property(),
+        "label": Property(identifier=True),
         "objects": Property(),
         "size": Property(),
     }

test/unit/objects/linode_test.py

@@ -554,6 +554,14 @@ def test_interface_ipv4(self):
         self.assertEqual(ipv4.vpc, "10.0.0.1")
         self.assertEqual(ipv4.nat_1_1, "any")
 
+    def test_config_devices_unwrap(self):
+        """
+        Tests that config devices can be successfully converted to a dict.
+        """
+
+        inst = Instance(self.client, 123)
+        assert inst.configs[0].devices.dict.get("sda").get("id") == 12345
+
 
 class StackScriptTest(ClientBaseCase):
     """