Skip to content

Commit 38a6e9e

Browse files
committed
Realloc failure leaves memory safety issue
Set *rulep = NULL before free(rule) in the realloc failure branch, preventing stale pointer.
1 parent 695433c commit 38a6e9e

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

lib/libaudit.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1842,6 +1842,7 @@ int audit_rule_fieldpair_data(struct audit_rule_data **rulep, char *pair,
18421842
rule->buflen += vlen;
18431843
tmp = realloc(rule, sizeof(*rule) + rule->buflen);
18441844
if (tmp == NULL) {
1845+
*rulep = NULL;
18451846
free(rule);
18461847
audit_msg(LOG_ERR, "Cannot realloc memory!");
18471848
return -3;

0 commit comments

Comments
 (0)