Fix static analysis findings

Author: stevegrubb

audisp/plugins/remote/remote-config.h

@@ -47,7 +47,7 @@ typedef struct remote_conf
 	unsigned int max_tries_per_record;
 	unsigned int max_time_per_record;
 	unsigned int heartbeat_timeout;
-	const char *krb5_principal;
+	char *krb5_principal;	// gssapi code inserts '@' into the string
 	const char *krb5_client_name;
 	const char *krb5_key_file;
 

auparse/auparse.c

@@ -2234,16 +2234,16 @@ static const char *auparse_interpret_sock_parts(auparse_state_t *au,
 		if (tmp == NULL)
 			return NULL;
 		// Locate the address part
-		val = strstr(tmp, field);
-		if (val) {
+		char *aval = strstr(tmp, field);
+		if (aval) {
 			// Get past the =
-			val += strlen(field);
+			aval += strlen(field);
 			// find other side
-			char *ptr = strchr(val, ' ');
+			char *ptr = strchr(aval, ' ');
 			if (ptr) {
 				// terminate, copy, and return it
 				*ptr = 0;
-				const char *final = strdup(val);
+				const char *final = strdup(aval);
 				free(tmp);
 				free((void *)au->tmp_translation);
 				au->tmp_translation = final;

src/auditd-config.h

@@ -90,7 +90,7 @@ struct daemon_conf
 	unsigned long tcp_client_max_port;
 	unsigned long tcp_client_max_idle;
 	int transport;
-	char *krb5_principal;	// gssapi code inserts @ sometimes
+	const char *krb5_principal;
 	const char *krb5_key_file;
 	int distribute_network_events;
 	// Dispatcher config