Fix more static analysis issues

Author: stevegrubb

audisp/audispd-pconfig.c

@@ -235,6 +235,7 @@ int load_pconfig(plugin_conf_t *config, int dirfd, char *file)
 			continue;
 		}
 		if (nv.values == NULL) {
+			nv_free(&nv);
 			fclose(f);
 			return 1;
 		}
@@ -543,4 +544,3 @@ void free_pconfig(plugin_conf_t *config)
 	free((void *)config->path);
 	free((void *)config->name);
 }
-

audisp/plugins/zos-remote/zos-remote-ldap.c

@@ -597,12 +597,14 @@ static int decode_response(audit_response_t * r, struct berval *bv)
         }
         rc |= ber_scanf(ber, "}");
 
-        if (rc == -1) {
-                for (; r->numItems > 0; r->numItems--)
-                        free(r->itemList[r->numItems - 1]);
-                free(r->itemList);
-                rc = ICTX_E_ABORT;
-        }
+	if (rc == -1) {
+		for (; r->numItems > 0; r->numItems--)
+			free(r->itemList[r->numItems - 1]);
+		free(r->itemList);
+		r->itemList = NULL;
+		r->numItems = 0;
+		rc = ICTX_E_ABORT;
+	}
         else
             rc = ICTX_SUCCESS;
 

src/ausearch-string.c

@@ -122,7 +122,10 @@ int slist_add_if_uniq(slist *l, const char *str)
 	sn.str = strdup(str);
 	sn.key = NULL;
 	sn.hits = 1;
-	slist_append(l, &sn);
+	if (slist_append(l, &sn)) {
+		free(sn.str);
+		return -1;
+	}
 	return 1;
 }
 
@@ -252,4 +255,3 @@ void slist_sort_by_hits(slist *l)
 	// End with cur pointing at first record
 	l->cur = l->head;
 }
-