Skip to content

Commit 1cddc54

Browse files
committed
ui: status: show flakes as 'flake'
Distinguish flakes more clearly. Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent a931926 commit 1cddc54

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

ui/status.js

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ function colorify_basic(value)
152152
{
153153
return colorify_str_any(value, {"fail": "red",
154154
"pass": "green",
155+
"flake": "orange",
155156
"pending": "#809fff"});
156157
}
157158

@@ -730,9 +731,18 @@ function load_result_table_one(data_raw, table, reported, avgs)
730731
var fcell = frow.insertCell(1);
731732
fcell.innerHTML = r.test;
732733
fcell.setAttribute("style", "text-align: right");
733-
frow.insertCell(2).innerHTML = colorify_basic(r.result);
734-
if ("retry" in r)
735-
frow.insertCell(3).innerHTML = colorify_basic(r.retry);
734+
735+
let result = r.result, retry = null;
736+
if ("retry" in r && r.retry == "pass")
737+
result = "flake";
738+
else if ("retry" in r)
739+
retry = r.retry;
740+
frow.insertCell(2).innerHTML = colorify_basic(result);
741+
if (retry)
742+
frow.insertCell(3).innerHTML = colorify_basic(retry);
743+
else
744+
frow.insertCell(3).innerText = "";
745+
frow.insertCell(4).innerText = "";
736746

737747
if ("crashes" in r) {
738748
$.each(r.crashes, function(ci, crash) {

0 commit comments

Comments
 (0)