air: support feedback about reviews

We need some way of knowing whether reviews were correct or not.
Add CLI for marking the reviews as "emailed" (presumably correct-ish)
"false-positive" and "false-negative".

Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Author: kuba-moo

air-email-review.py

@@ -68,6 +68,17 @@ def get_review(self, review_id: str, fmt: str = 'inline') -> Dict:
         response.raise_for_status()
         return response.json()
 
+    def set_feedback(self, review_id: str, feedback: str) -> bool:
+        """Set feedback for a review"""
+        data = {'id': review_id, 'feedback': feedback}
+        if self.token:
+            data['token'] = self.token
+
+        response = self.session.post(f"{self.air_url}/api/review/feedback",
+                                     json=data, timeout=30)
+        response.raise_for_status()
+        return response.json().get('success', False)
+
     def get_patchwork_series(self, series_id: int) -> Dict:
         """Fetch series info from Patchwork API"""
         response = self.session.get(
@@ -440,6 +451,8 @@ def main():
                         help='Only send replies for specific patch numbers (1-based, can be repeated)')
     parser.add_argument('--pw-bot', dest='pw_bot', metavar='STRING',
                         help='Add "pw-bot: STRING" footer to the first review email')
+    parser.add_argument('--no-feedback', dest='no_feedback', action='store_true',
+                        help='Do not set feedback on the review (default: sets "emailed")')
 
     args = parser.parse_args()
 
@@ -523,6 +536,17 @@ def main():
 
     reviews = review.get('review', [])
 
+    # Set feedback to "emailed" unless --no-feedback is set
+    if args.no_feedback:
+        print("Skipping feedback (--no-feedback)")
+    else:
+        print("Setting feedback to 'emailed'...")
+        try:
+            client.set_feedback(args.review_id, 'emailed')
+            print(colorize("Feedback set: emailed", Colors.GREEN))
+        except requests.exceptions.RequestException as e:
+            print(f"Warning: Failed to set feedback: {e}", file=sys.stderr)
+
     # Extract recipients from patches
     to_addrs, cc_addrs = extract_recipients(patch_info_list)
 

air-submit.py

@@ -202,6 +202,39 @@ def delete_review(url: str, token: str, review_id: str) -> bool:
         sys.exit(1)
 
 
+def set_feedback(url: str, token: Optional[str], review_id: str, feedback: str) -> bool:
+    """Set feedback for a review
+
+    Args:
+        url: AIR service URL
+        token: API token (optional for public reviews)
+        review_id: Review ID
+        feedback: Feedback value (emailed, false-positive, false-negative)
+
+    Returns:
+        True if successful
+    """
+    api_url = f"{url}/api/review/feedback"
+    data = {
+        'id': review_id,
+        'feedback': feedback,
+    }
+
+    if token:
+        data['token'] = token
+
+    try:
+        response = requests.post(api_url, json=data, timeout=30)
+        response.raise_for_status()
+        return response.json().get('success', False)
+    except requests.exceptions.RequestException as e:
+        print(f"Error setting feedback: {e}", file=sys.stderr)
+        sys.exit(1)
+    except json.JSONDecodeError as e:
+        print(f"Error parsing response: {e}", file=sys.stderr)
+        sys.exit(1)
+
+
 def format_status_line(status: dict) -> str:
     """Format one-line status summary with color
 
@@ -331,6 +364,8 @@ def main():
                        help='Existing review ID to check (skip submission)')
     parser.add_argument('--delete', action='store_true',
                        help='Delete the specified review (requires --review-id and superuser token)')
+    parser.add_argument('--feedback', choices=['emailed', 'false-positive', 'false-negative'],
+                       help='Set feedback for a review (requires --review-id)')
     parser.add_argument('patches', nargs='*', metavar='PATCH_FILE',
                        help='Patch files to submit')
 
@@ -380,6 +415,20 @@ def main():
             sys.exit(1)
         return
 
+    # Handle --feedback operation
+    if args.feedback:
+        if not args.review_id:
+            parser.error('--feedback requires --review-id')
+
+        print(f"Setting feedback to '{args.feedback}' for review {args.review_id}...")
+        success = set_feedback(args.url, args.token, args.review_id, args.feedback)
+        if success:
+            print(colorize(f"Feedback set: {args.feedback}", Colors.GREEN))
+        else:
+            print(colorize("Failed to set feedback", Colors.RED), file=sys.stderr)
+            sys.exit(1)
+        return
+
     # Validate arguments
     if args.review_id:
         review_id = args.review_id