contest: hw: remove the seen handling

We explicitly add random chars to kernel version, the collisions
of kernel versions should not happen. Remove the .seen markers
because they interfere with continuing tests after reboot.
We could just remove the correct one but really the seen stuff
is pointless.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Author: kuba-moo

contest/hw/README.rst

@@ -408,10 +408,6 @@ coordinate crash recovery between hwksft and hw-worker:
   tests in this list are skipped and reported as failures. This ensures
   a crashing test is never retried.
 
-``.seen``
-  Standard "already picked up" marker (an empty file created in each
-  test directory). Prevents re-discovery of old test sets.
-
 hw-worker
 =========
 
@@ -428,22 +424,20 @@ Operation
    ``uname -r``. If the running kernel doesn't match, this is a boot into
    the wrong kernel (e.g. default kernel after power cycle) — exit
    immediately.
-3. Mark all entries under ``/srv/hw-worker/tests`` as "seen" (create a
-   ``.seen`` file in each directory). This prevents loop-testing the same set.
-4. Open ``/dev/kmsg`` and drain existing boot messages to
+3. Open ``/dev/kmsg`` and drain existing boot messages to
    ``results_dir/boot-dmesg``.
-5. Run the tests. For each test:
+4. Run the tests. For each test:
     a. Check if test name is in ``.attempted`` — if so, skip (crash recovery).
     b. Write test name to ``.attempted`` + fsync before execution.
     c. Run via ``./run_kselftest.sh -t <target>:<test>`` (installed form).
     d. Capture stdout/stderr, save to ``results_dir/<idx>-<name>/``.
     e. Drain ``/dev/kmsg`` — if any dmesg output was produced during
        the test, save it to ``results_dir/<idx>-<name>/dmesg``.
     f. Save metadata to ``results_dir/<idx>-<name>/info`` (JSON).
-6. Results are saved under ``/srv/hw-worker/results/$reservation_id/``.
+5. Results are saved under ``/srv/hw-worker/results/$reservation_id/``.
    hw-worker does **not** determine pass/fail — that is done by hwksft
    when it copies back and parses the output files.
-7. Service exits.
+6. Service exits.
 
 Output artifacts
 ----------------

contest/hw/hw_worker.py

@@ -9,7 +9,7 @@
 import sys
 import time
 
-from lib.runner import find_newest_unseen, mark_all_seen, run_tests
+from lib.runner import find_newest_test, run_tests
 
 
 TESTS_DIR = '/srv/hw-worker/tests'
@@ -219,7 +219,7 @@ def main():
     tests_dir = TESTS_DIR
     results_base = RESULTS_DIR
 
-    test_dir = find_newest_unseen(tests_dir)
+    test_dir = find_newest_test(tests_dir)
     if test_dir is None:
         print("No outstanding tests found")
         return
@@ -243,8 +243,6 @@ def main():
               f"Kernel mismatch: running {actual}, expected {expected}")
         return
 
-    mark_all_seen(tests_dir)
-
     print(test_dir, "Starting tests")
 
     # Configure test interfaces and write net.config

contest/hw/lib/runner.py

@@ -10,8 +10,8 @@
 from lib.nipa import has_crash, extract_crash, namify
 
 
-def find_newest_unseen(tests_dir):
-    """Scan tests_dir for subdirectories without .seen file.
+def find_newest_test(tests_dir):
+    """Scan tests_dir for the newest test subdirectory.
 
     Returns the newest one (by mtime) or None.
     """
@@ -23,8 +23,6 @@ def find_newest_unseen(tests_dir):
         full = os.path.join(tests_dir, entry)
         if not os.path.isdir(full):
             continue
-        if os.path.exists(os.path.join(full, '.seen')):
-            continue
         candidates.append((os.path.getmtime(full), full))
 
     if not candidates:
@@ -34,21 +32,6 @@ def find_newest_unseen(tests_dir):
     return candidates[0][1]
 
 
-def mark_all_seen(tests_dir):
-    """Touch .seen file in every subdirectory of tests_dir."""
-    if not os.path.isdir(tests_dir):
-        return
-
-    for entry in os.listdir(tests_dir):
-        full = os.path.join(tests_dir, entry)
-        if not os.path.isdir(full):
-            continue
-        seen_path = os.path.join(full, '.seen')
-        if not os.path.exists(seen_path):
-            with open(seen_path, 'w', encoding='utf-8') as fp:
-                fp.write('')
-
-
 def load_attempted(test_dir):
     """Load .attempted file (JSON list of test names already tried).
 

contest/hw/tests/test_hw_worker.py

@@ -10,31 +10,21 @@
 
 sys.path.insert(0, os.path.join(os.path.dirname(__file__), '..'))
 
-from lib.runner import (find_newest_unseen, mark_all_seen, load_attempted,
+from lib.runner import (find_newest_test, load_attempted,
                         mark_attempted, run_tests, DmesgReader)
 from lib.nipa import namify
 
 
-class TestFindNewestUnseen(unittest.TestCase):
-    def test_single_unseen(self):
+class TestFindNewestTest(unittest.TestCase):
+    def test_single_dir(self):
         with tempfile.TemporaryDirectory() as tmpdir:
             test_dir = os.path.join(tmpdir, 'test1')
             os.makedirs(test_dir)
 
-            result = find_newest_unseen(tmpdir)
+            result = find_newest_test(tmpdir)
             self.assertEqual(result, test_dir)
 
-    def test_all_seen(self):
-        with tempfile.TemporaryDirectory() as tmpdir:
-            test_dir = os.path.join(tmpdir, 'test1')
-            os.makedirs(test_dir)
-            with open(os.path.join(test_dir, '.seen'), 'w') as fp:
-                fp.write('')
-
-            result = find_newest_unseen(tmpdir)
-            self.assertIsNone(result)
-
-    def test_multiple_unseen_picks_newest(self):
+    def test_multiple_picks_newest(self):
         with tempfile.TemporaryDirectory() as tmpdir:
             dir1 = os.path.join(tmpdir, 'test1')
             dir2 = os.path.join(tmpdir, 'test2')
@@ -46,43 +36,19 @@ def test_multiple_unseen_picks_newest(self):
             time.sleep(0.1)
             os.utime(dir2, None)
 
-            result = find_newest_unseen(tmpdir)
+            result = find_newest_test(tmpdir)
             self.assertEqual(result, dir2)
 
     def test_empty_dir(self):
         with tempfile.TemporaryDirectory() as tmpdir:
-            result = find_newest_unseen(tmpdir)
+            result = find_newest_test(tmpdir)
             self.assertIsNone(result)
 
     def test_nonexistent_dir(self):
-        result = find_newest_unseen('/nonexistent/path')
+        result = find_newest_test('/nonexistent/path')
         self.assertIsNone(result)
 
 
-class TestMarkAllSeen(unittest.TestCase):
-    def test_marks_all(self):
-        with tempfile.TemporaryDirectory() as tmpdir:
-            for name in ['test1', 'test2', 'test3']:
-                os.makedirs(os.path.join(tmpdir, name))
-
-            mark_all_seen(tmpdir)
-
-            for name in ['test1', 'test2', 'test3']:
-                self.assertTrue(
-                    os.path.exists(os.path.join(tmpdir, name, '.seen'))
-                )
-
-    def test_already_seen_not_error(self):
-        with tempfile.TemporaryDirectory() as tmpdir:
-            test_dir = os.path.join(tmpdir, 'test1')
-            os.makedirs(test_dir)
-            with open(os.path.join(test_dir, '.seen'), 'w') as fp:
-                fp.write('')
-
-            # Should not raise
-            mark_all_seen(tmpdir)
-
-
 class TestKernelVersionCheck(unittest.TestCase):
     @mock.patch('os.uname',
                 return_value=mock.Mock(release='5.15.0-generic'))
@@ -494,10 +460,6 @@ def test_full_run(self, mock_run, mock_dmesg_cls, mock_uname):
             self.assertTrue(os.path.exists(os.path.join(test_output, 'info')))
             self.assertTrue(os.path.exists(os.path.join(test_output, 'stdout')))
 
-            # .seen should be created
-            seen_path = os.path.join(test_dir, '.seen')
-            self.assertTrue(os.path.exists(seen_path))
-
     @mock.patch('os.uname')
     @mock.patch('lib.runner.DmesgReader')
     @mock.patch('subprocess.run')