air: add --llm-mode support

Chris has announced new way of running the LLM reviews:
https://lore.kernel.org/b187e0c1-1df8-4529-bfe4-0a1d65221adc@meta.com

Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Author: kuba-moo

air-submit.py

@@ -85,7 +85,8 @@ def submit_review(url: str, token: str, tree: str, branch: Optional[str],
                   patches: Optional[List[str]] = None,
                   patchwork_series_id: Optional[int] = None,
                   chash: Optional[str] = None,
-                  model: Optional[str] = None) -> str:
+                  model: Optional[str] = None,
+                  llm_mode: Optional[str] = None) -> str:
     """Submit patches for review
 
     Args:
@@ -97,6 +98,7 @@ def submit_review(url: str, token: str, tree: str, branch: Optional[str],
         patchwork_series_id: Patchwork series ID (or None if using patches/hash)
         chash: Git hash or range (or None if using patches/patchwork)
         model: Optional model name (sonnet, opus, haiku)
+        llm_mode: Optional LLM mode (classic, orc)
 
     Returns:
         Review ID
@@ -124,6 +126,9 @@ def submit_review(url: str, token: str, tree: str, branch: Optional[str],
     if model:
         payload['model'] = model
 
+    if llm_mode:
+        payload['llm_mode'] = llm_mode
+
     try:
         response = requests.post(api_url, json=payload, timeout=30)
         response.raise_for_status()
@@ -301,6 +306,7 @@ def main():
     tree = netdev/net-next
     branch = main
     model = sonnet
+    llm_mode = classic
 
   Command-line arguments always override config file values.
   To unset a config value, pass an empty string:
@@ -320,6 +326,8 @@ def main():
                        help='Git branch name (optional)')
     parser.add_argument('--model',
                        help='Claude model to use (e.g., sonnet, opus, haiku) [optional]')
+    parser.add_argument('--llm-mode', choices=['classic', 'orc'],
+                       help='LLM review mode: classic (default) or orc (agent-based)')
     parser.add_argument('--format', choices=['json', 'markup', 'inline'],
                        default='inline',
                        help='Review output format (default: inline)')
@@ -353,6 +361,8 @@ def main():
             args.branch = config.get('air', 'branch')
         if args.model is None and config.has_option('air', 'model'):
             args.model = config.get('air', 'model')
+        if getattr(args, 'llm_mode', None) is None and config.has_option('air', 'llm_mode'):
+            args.llm_mode = config.get('air', 'llm_mode')
 
     # Convert empty strings to None (allows unsetting config values)
     if args.token == '':
@@ -361,6 +371,8 @@ def main():
         args.branch = None
     if args.model == '':
         args.model = None
+    if getattr(args, 'llm_mode', None) == '':
+        args.llm_mode = None
 
     # Validate that we have URL
     if not args.url:
@@ -408,19 +420,22 @@ def main():
             review_id = submit_review(args.url, args.token, args.tree,
                                       args.branch,
                                       patchwork_series_id=args.pw_series,
-                                      model=args.model)
+                                      model=args.model,
+                                      llm_mode=getattr(args, 'llm_mode', None))
         elif args.hash:
             print(f"Submitting git hash/range {args.hash} to {args.tree}...")
             review_id = submit_review(args.url, args.token, args.tree,
                                       args.branch, chash=args.hash,
-                                      model=args.model)
+                                      model=args.model,
+                                      llm_mode=getattr(args, 'llm_mode', None))
         else:
             print(f"Reading {len(args.patches)} patch file(s)...")
             patches = read_patch_files(args.patches)
             print(f"Submitting to {args.tree}...")
             review_id = submit_review(args.url, args.token, args.tree,
                                       args.branch, patches=patches,
-                                      model=args.model)
+                                      model=args.model,
+                                      llm_mode=getattr(args, 'llm_mode', None))
 
         print(f"Review ID: {review_id}")
 

ui/ai-local.html

@@ -263,17 +263,53 @@ <h2>Review Prompts</h2>
       Clone this repository to get the latest prompts, and ask your
       favorite LLM to use them to review your code.
     </p>
+
+    <h3>Review Modes</h3>
     <p>
-      The exact prompt we use on netdev is:
+      There are two modes for running reviews:
+    </p>
+
+    <h4>Classic Mode</h4>
+    <p>
+      The original single-prompt mode. Works well for small to medium patches.
     </p>
     <div class="prompt-text">Current directory is the root of a Linux Kernel git repository.
 Read the prompt from kernel/review-core.md.
 Using the prompt, do a deep dive regression analysis of the HEAD commit.
 Use commit range &lt;base&gt;..&lt;head&gt; for the false-positive-guide.md section.</div>
 
+    <h4>Orc Mode (Recommended for Large Patches)</h4>
+    <p>
+      The newer agent-based mode that breaks the review into individual tasks.
+      This mode is recommended for large diffs because it:
+    </p>
+    <ul>
+      <li>Breaks large diffs into smaller chunks and reviews each chunk individually</li>
+      <li>Uses fewer tokens by avoiding repeated context for the entire diff</li>
+      <li>Catches more bugs through focused analysis of each section</li>
+      <li>Pre-processes the code to extract modified functions, types, and call graphs</li>
+    </ul>
+
+    <p>To use orc mode, first run the preprocessing script:</p>
+    <pre><code>cd /path/to/linux
+kernel/scripts/create_changes.py HEAD</code></pre>
+
+    <p>Then invoke the LLM with the orc prompt:</p>
+    <div class="prompt-text">Current directory is the root of a Linux Kernel git repository.
+Read the prompt from kernel/agent/orc.md and run it on the HEAD commit.</div>
+
+    <div class="note">
+        <div class="note-title">When to use Orc Mode</div>
+        <p>
+          Use orc mode for patches with large diffs, multiple files, or complex changes.
+          The preprocessing step extracts context that helps the LLM focus on relevant code
+          without spending tokens discovering it on its own.
+        </p>
+    </div>
+
     <p>
       Where <code>&lt;base&gt;..&lt;head&gt;</code> should be replaced by a real
-      git commit hash range.
+      git commit hash range (classic mode only).
     </p>
 
     <h2>Output Format</h2>

ui/ai-review.html

@@ -341,6 +341,10 @@ <h2>Review Information <span style="font-family: monospace; font-size: 0.75em; f
                     <label>Model:</label>
                     <span id="review-model"></span>
                 </div>
+                <div class="review-info-item" id="llm-mode-info" style="display: none;">
+                    <label>Mode:</label>
+                    <span id="review-llm-mode"></span>
+                </div>
                 <div class="review-info-item">
                     <label>Submitted:</label>
                     <span id="review-date"></span>
@@ -387,6 +391,7 @@ <h2>Review Information <span style="font-family: monospace; font-size: 0.75em; f
             <select id="format" onchange="changeFormat()">
                 <option value="inline">Review</option>
                 <option value="markup">Full output</option>
+                <option value="metadata">Metadata</option>
             </select>
         </div>
 
@@ -517,6 +522,12 @@ <h2>Review Information <span style="font-family: monospace; font-size: 0.75em; f
                 document.getElementById('review-model').textContent = data.model;
             }
 
+            // LLM Mode
+            if (data.llm_mode) {
+                document.getElementById('llm-mode-info').style.display = 'block';
+                document.getElementById('review-llm-mode').textContent = data.llm_mode;
+            }
+
             // Patchwork series ID
             if (data.patchwork_series_id) {
                 document.getElementById('patchwork-info').style.display = 'block';