ynl-gen-cpp: generate code for notification handling

The code generator was not generating code to initialize
ynl_ntf_info::alloc_sz() and ynl_ntf_info::free().

For type casting in and out of ynl_ntf_base_type, I had the code
generator create structs in a similar way to the ynl-c repo. The code
generator was already doing this but leaving them empty.

In the free function, the C++ needs to be manually called before
freeing the memory that was allocated with calloc()

Signed-off-by: Daniel Zahka <daniel.zahka@gmail.com>

Author: Daniel Zahka

generated/binder-user.cpp

@@ -127,10 +127,18 @@ int binder_report_rsp_parse(const struct nlmsghdr *nlh,
 	return YNL_PARSE_CB_OK;
 }
 
+static void binder_report_free(struct ynl_ntf_base_type* ntf) {
+	auto* typed_ntf = reinterpret_cast<binder_report*>(ntf);
+	typed_ntf->obj.~binder_report_rsp();
+	free(ntf);
+}
+
 static constexpr std::array<ynl_ntf_info, BINDER_CMD_REPORT + 1> binder_ntf_info = []() {
 	std::array<ynl_ntf_info, BINDER_CMD_REPORT + 1> arr{};
 	arr[BINDER_CMD_REPORT].policy		= &binder_report_nest;
 	arr[BINDER_CMD_REPORT].cb		= binder_report_rsp_parse;
+	arr[BINDER_CMD_REPORT].alloc_sz	= sizeof(binder_report);
+	arr[BINDER_CMD_REPORT].free		= binder_report_free;
 	return arr;
 } ();
 

generated/binder-user.hpp

@@ -44,6 +44,11 @@ struct binder_report_rsp {
 };
 
 struct binder_report {
+	__u16 family;
+	__u8 cmd;
+	struct ynl_ntf_base_type* next;
+	void (*free)(struct ynl_ntf_base_type* ntf);
+	binder_report_rsp obj __attribute__((aligned(8)));
 };
 
 } //namespace ynl_cpp

generated/dpll-user.cpp

@@ -756,6 +756,12 @@ dpll_device_get_dump(ynl_cpp::ynl_socket& ys)
 }
 
 /* DPLL_CMD_DEVICE_GET - notify */
+static void dpll_device_get_ntf_free(struct ynl_ntf_base_type* ntf) {
+	auto* typed_ntf = reinterpret_cast<dpll_device_get_ntf*>(ntf);
+	typed_ntf->obj.~dpll_device_get_rsp();
+	free(ntf);
+}
+
 /* ============== DPLL_CMD_DEVICE_SET ============== */
 /* DPLL_CMD_DEVICE_SET - do */
 int dpll_device_set(ynl_cpp::ynl_socket& ys, dpll_device_set_req& req)
@@ -1118,6 +1124,12 @@ dpll_pin_get_dump(ynl_cpp::ynl_socket& ys, dpll_pin_get_req_dump& req)
 }
 
 /* DPLL_CMD_PIN_GET - notify */
+static void dpll_pin_get_ntf_free(struct ynl_ntf_base_type* ntf) {
+	auto* typed_ntf = reinterpret_cast<dpll_pin_get_ntf*>(ntf);
+	typed_ntf->obj.~dpll_pin_get_rsp();
+	free(ntf);
+}
+
 /* ============== DPLL_CMD_PIN_SET ============== */
 /* DPLL_CMD_PIN_SET - do */
 int dpll_pin_set(ynl_cpp::ynl_socket& ys, dpll_pin_set_req& req)
@@ -1172,16 +1184,28 @@ static constexpr std::array<ynl_ntf_info, DPLL_CMD_PIN_CHANGE_NTF + 1> dpll_ntf_
 	std::array<ynl_ntf_info, DPLL_CMD_PIN_CHANGE_NTF + 1> arr{};
 	arr[DPLL_CMD_DEVICE_CREATE_NTF].policy		= &dpll_nest;
 	arr[DPLL_CMD_DEVICE_CREATE_NTF].cb		= dpll_device_get_rsp_parse;
+	arr[DPLL_CMD_DEVICE_CREATE_NTF].alloc_sz	= sizeof(dpll_device_get_ntf);
+	arr[DPLL_CMD_DEVICE_CREATE_NTF].free		= dpll_device_get_ntf_free;
 	arr[DPLL_CMD_DEVICE_DELETE_NTF].policy		= &dpll_nest;
 	arr[DPLL_CMD_DEVICE_DELETE_NTF].cb		= dpll_device_get_rsp_parse;
+	arr[DPLL_CMD_DEVICE_DELETE_NTF].alloc_sz	= sizeof(dpll_device_get_ntf);
+	arr[DPLL_CMD_DEVICE_DELETE_NTF].free		= dpll_device_get_ntf_free;
 	arr[DPLL_CMD_DEVICE_CHANGE_NTF].policy		= &dpll_nest;
 	arr[DPLL_CMD_DEVICE_CHANGE_NTF].cb		= dpll_device_get_rsp_parse;
+	arr[DPLL_CMD_DEVICE_CHANGE_NTF].alloc_sz	= sizeof(dpll_device_get_ntf);
+	arr[DPLL_CMD_DEVICE_CHANGE_NTF].free		= dpll_device_get_ntf_free;
 	arr[DPLL_CMD_PIN_CREATE_NTF].policy		= &dpll_pin_nest;
 	arr[DPLL_CMD_PIN_CREATE_NTF].cb		= dpll_pin_get_rsp_parse;
+	arr[DPLL_CMD_PIN_CREATE_NTF].alloc_sz	= sizeof(dpll_pin_get_ntf);
+	arr[DPLL_CMD_PIN_CREATE_NTF].free		= dpll_pin_get_ntf_free;
 	arr[DPLL_CMD_PIN_DELETE_NTF].policy		= &dpll_pin_nest;
 	arr[DPLL_CMD_PIN_DELETE_NTF].cb		= dpll_pin_get_rsp_parse;
+	arr[DPLL_CMD_PIN_DELETE_NTF].alloc_sz	= sizeof(dpll_pin_get_ntf);
+	arr[DPLL_CMD_PIN_DELETE_NTF].free		= dpll_pin_get_ntf_free;
 	arr[DPLL_CMD_PIN_CHANGE_NTF].policy		= &dpll_pin_nest;
 	arr[DPLL_CMD_PIN_CHANGE_NTF].cb		= dpll_pin_get_rsp_parse;
+	arr[DPLL_CMD_PIN_CHANGE_NTF].alloc_sz	= sizeof(dpll_pin_get_ntf);
+	arr[DPLL_CMD_PIN_CHANGE_NTF].free		= dpll_pin_get_ntf_free;
 	return arr;
 } ();
 

generated/dpll-user.hpp

@@ -118,6 +118,11 @@ dpll_device_get_dump(ynl_cpp::ynl_socket& ys);
 
 /* DPLL_CMD_DEVICE_GET - notify */
 struct dpll_device_get_ntf {
+	__u16 family;
+	__u8 cmd;
+	struct ynl_ntf_base_type* next;
+	void (*free)(struct ynl_ntf_base_type* ntf);
+	dpll_device_get_rsp obj __attribute__((aligned(8)));
 };
 
 /* ============== DPLL_CMD_DEVICE_SET ============== */
@@ -212,6 +217,11 @@ dpll_pin_get_dump(ynl_cpp::ynl_socket& ys, dpll_pin_get_req_dump& req);
 
 /* DPLL_CMD_PIN_GET - notify */
 struct dpll_pin_get_ntf {
+	__u16 family;
+	__u8 cmd;
+	struct ynl_ntf_base_type* next;
+	void (*free)(struct ynl_ntf_base_type* ntf);
+	dpll_pin_get_rsp obj __attribute__((aligned(8)));
 };
 
 /* ============== DPLL_CMD_PIN_SET ============== */