xapp-gpu-offload-helper.c: Fix a memory leak.

mtwebster · mtwebster · commit 6e4d54cad084 · 2026-03-11T13:00:52.000-04:00
Noticed this while running cinnamon thru valgrind.
diff --git a/libxapp/xapp-gpu-offload-helper.c b/libxapp/xapp-gpu-offload-helper.c
@@ -296,6 +296,8 @@ helper_init_thread (GTask        *task,
 {
     XAppGpuOffloadHelper *helper = XAPP_GPU_OFFLOAD_HELPER (source_object);
     XAppSwitcherooControl *control;
+    g_autofree gchar *name_owner = NULL;
+
     GError *error = NULL;
 
     control = xapp_switcheroo_control_proxy_new_for_bus_sync (G_BUS_TYPE_SYSTEM,
@@ -316,7 +318,9 @@ helper_init_thread (GTask        *task,
         g_task_return_error (task, error);
     }
 
-    if (g_dbus_proxy_get_name_owner (G_DBUS_PROXY (control)) != NULL)
+    name_owner = g_dbus_proxy_get_name_owner (G_DBUS_PROXY (control));
+
+    if (name_owner != NULL)
     {
         DEBUG ("Got switcheroo-control proxy successfully");
 

Original file line number	Diff line number	Diff line change
`@@ -296,6 +296,8 @@ helper_init_thread (GTask *task,`
`296`	`296`	`{`
`297`	`297`	`XAppGpuOffloadHelper *helper = XAPP_GPU_OFFLOAD_HELPER (source_object);`
`298`	`298`	`XAppSwitcherooControl *control;`
	`299`	`+ g_autofree gchar *name_owner = NULL;`
	`300`	`+`
`299`	`301`	`GError *error = NULL;`
`300`	`302`
`301`	`303`	`control = xapp_switcheroo_control_proxy_new_for_bus_sync (G_BUS_TYPE_SYSTEM,`
`@@ -316,7 +318,9 @@ helper_init_thread (GTask *task,`
`316`	`318`	`g_task_return_error (task, error);`
`317`	`319`	`}`
`318`	`320`
`319`		`- if (g_dbus_proxy_get_name_owner (G_DBUS_PROXY (control)) != NULL)`
	`321`	`+ name_owner = g_dbus_proxy_get_name_owner (G_DBUS_PROXY (control));`
	`322`	`+`
	`323`	`+ if (name_owner != NULL)`
`320`	`324`	`{`
`321`	`325`	`DEBUG ("Got switcheroo-control proxy successfully");`
`322`	`326`