Better appearance (#234)

* EvPageActionWidget: don't use vertical margin

Don't set vertical margin for this widget. Margin makes toolbar bigger than should be, defined by
theme.

* Update shell CSS styles

To make it working.

* EvSidebar*, EvWindow: avoid useless shadows

They are ugly.

* EvSidebar*: add horizontal separator

To make UI more readable after previous commit.

Author: TomaszGasior

libmisc/ev-page-action-widget.c

@@ -240,7 +240,7 @@ ev_page_action_widget_init (EvPageActionWidget *action_widget)
 			    FALSE, FALSE, 0);
 	gtk_widget_show (action_widget->label);
 
-	gtk_container_set_border_width (GTK_CONTAINER (action_widget), 6);
+	g_object_set (G_OBJECT (action_widget), "margin-left", 8, "margin-right", 8, NULL);
 	gtk_container_add (GTK_CONTAINER (action_widget), hbox);
 	gtk_widget_show (hbox);
 

shell/ev-sidebar-annotations.c

@@ -139,6 +139,7 @@ ev_sidebar_annotations_init (EvSidebarAnnotations *ev_annots)
 	GtkCellRenderer *renderer;
 	GtkTreeViewColumn *column;
 	GtkTreeSelection *selection;
+	GtkWidget *separator;
 	GtkWidget *toolbar;
 	GtkWidget *toolitem;
 	GtkWidget *hbox;
@@ -150,7 +151,6 @@ ev_sidebar_annotations_init (EvSidebarAnnotations *ev_annots)
 	gtk_orientable_set_orientation (GTK_ORIENTABLE (ev_annots), GTK_ORIENTATION_VERTICAL);
 
 	swindow = gtk_scrolled_window_new (NULL, NULL);
-	gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (swindow), GTK_SHADOW_IN);
 	gtk_box_pack_start (GTK_BOX (ev_annots), swindow, TRUE, TRUE, 0);
 	gtk_widget_show (swindow);
 
@@ -181,6 +181,10 @@ ev_sidebar_annotations_init (EvSidebarAnnotations *ev_annots)
 	gtk_container_add (GTK_CONTAINER (swindow), ev_annots->priv->tree_view);
 	gtk_widget_show (ev_annots->priv->tree_view);
 
+	separator = gtk_separator_new (GTK_ORIENTATION_HORIZONTAL);
+	gtk_box_pack_start (GTK_BOX (ev_annots), separator, FALSE, FALSE, 0);
+	gtk_widget_show (separator);
+
 	toolbar = gtk_toolbar_new ();
 	gtk_widget_show (toolbar);
 

shell/ev-sidebar-attachments.c

@@ -542,8 +542,6 @@ ev_sidebar_attachments_init (EvSidebarAttachments *ev_attachbar)
 	gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (swindow),
 					GTK_POLICY_NEVER,
 					GTK_POLICY_AUTOMATIC);
-	gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (swindow),
-					     GTK_SHADOW_IN);
 	/* Data Model */
 	ev_attachbar->priv->model = gtk_list_store_new (N_COLS,
 							GDK_TYPE_PIXBUF, 

shell/ev-sidebar-bookmarks.c

@@ -418,6 +418,7 @@ ev_sidebar_bookmarks_init (EvSidebarBookmarks *sidebar_bookmarks)
 {
         EvSidebarBookmarksPrivate *priv;
         GtkWidget *swindow;
+        GtkWidget *separator;
         GtkWidget *toolbar;
         GtkWidget *toolitem;
         GtkWidget *hbox;
@@ -433,8 +434,6 @@ ev_sidebar_bookmarks_init (EvSidebarBookmarks *sidebar_bookmarks)
         gtk_orientable_set_orientation (GTK_ORIENTABLE (sidebar_bookmarks), GTK_ORIENTATION_VERTICAL);
 
         swindow = gtk_scrolled_window_new (NULL, NULL);
-        gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (swindow),
-                                             GTK_SHADOW_IN);
         gtk_box_pack_start (GTK_BOX (sidebar_bookmarks), swindow, TRUE, TRUE, 0);
         gtk_widget_show (swindow);
 
@@ -469,6 +468,10 @@ ev_sidebar_bookmarks_init (EvSidebarBookmarks *sidebar_bookmarks)
         gtk_container_add (GTK_CONTAINER (swindow), priv->tree_view);
         gtk_widget_show (priv->tree_view);
 
+        separator = gtk_separator_new (GTK_ORIENTATION_HORIZONTAL);
+        gtk_box_pack_start (GTK_BOX (sidebar_bookmarks), separator, FALSE, FALSE, 0);
+        gtk_widget_show (separator);
+
         toolbar = gtk_toolbar_new ();
         gtk_widget_show (toolbar);
 

shell/ev-sidebar-links.c

@@ -396,9 +396,6 @@ ev_sidebar_links_construct (EvSidebarLinks *ev_sidebar_links)
 
 	swindow = gtk_scrolled_window_new (NULL, NULL);
 
-	gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (swindow),
-					     GTK_SHADOW_IN);
-
 	/* Create tree view */
 	loading_model = create_loading_model ();
 	priv->tree_view = gtk_tree_view_new_with_model (loading_model);

shell/ev-sidebar-thumbnails.c

@@ -884,6 +884,7 @@ static void
 ev_sidebar_thumbnails_init (EvSidebarThumbnails *ev_sidebar_thumbnails)
 {
 	EvSidebarThumbnailsPrivate *priv;
+	GtkWidget *separator;
 	guint signal_id;
 	GtkWidget *toolbar;
 	GtkWidget *toolitem;
@@ -912,8 +913,6 @@ ev_sidebar_thumbnails_init (EvSidebarThumbnails *ev_sidebar_thumbnails)
 
 	gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (priv->swindow),
 					GTK_POLICY_NEVER, GTK_POLICY_AUTOMATIC);
-	gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (priv->swindow),
-					     GTK_SHADOW_IN);
 	priv->vadjustment = gtk_scrolled_window_get_vadjustment (GTK_SCROLLED_WINDOW (priv->swindow));
 	g_signal_connect_data (priv->vadjustment, "value-changed",
 			       G_CALLBACK (adjustment_changed_cb),
@@ -924,6 +923,10 @@ ev_sidebar_thumbnails_init (EvSidebarThumbnails *ev_sidebar_thumbnails)
 				  ev_sidebar_thumbnails);
 	gtk_box_pack_start (GTK_BOX (ev_sidebar_thumbnails), priv->swindow, TRUE, TRUE, 0);
 
+	separator = gtk_separator_new (GTK_ORIENTATION_HORIZONTAL);
+	gtk_box_pack_start (GTK_BOX (ev_sidebar_thumbnails), separator, FALSE, FALSE, 0);
+	gtk_widget_show (separator);
+
 	toolbar = gtk_toolbar_new ();
 	gtk_widget_show (toolbar);
 

shell/ev-window.c

@@ -3944,10 +3944,6 @@ ev_window_run_fullscreen (EvWindow *window)
         fullscreen_window = FALSE;
     }
 
-    g_object_set (G_OBJECT (window->priv->scrolled_window),
-            "shadow-type", GTK_SHADOW_NONE,
-            NULL);
-
     ev_document_model_set_fullscreen (window->priv->model, TRUE);
     ev_window_update_fullscreen_action (window);
 
@@ -3979,10 +3975,6 @@ ev_window_stop_fullscreen (EvWindow *window,
     if (!ev_document_model_get_fullscreen (window->priv->model))
         return;
 
-    g_object_set (G_OBJECT (window->priv->scrolled_window),
-            "shadow-type", GTK_SHADOW_IN,
-            NULL);
-
     ev_document_model_set_fullscreen (window->priv->model, FALSE);
     ev_window_update_fullscreen_action (window);
     update_chrome_flag (window, EV_CHROME_FULLSCREEN_TOOLBAR, FALSE);
@@ -7546,7 +7538,6 @@ ev_window_init (EvWindow *ev_window)
     ev_window->priv->view_box = gtk_box_new(GTK_ORIENTATION_VERTICAL, 0);
     ev_window->priv->scrolled_window =
             GTK_WIDGET (g_object_new (GTK_TYPE_SCROLLED_WINDOW,
-                    "shadow-type", GTK_SHADOW_IN,
                     NULL));
     gtk_box_pack_start (GTK_BOX (ev_window->priv->view_box),
             ev_window->priv->scrolled_window,

shell/xreader.css

@@ -1,3 +1,12 @@
+.view.content-view {
+    background-color: @theme_bg_color;
+}
+
+.view.content-view:selected {
+    background-color: @theme_selected_bg_color;
+    color: @theme_selected_fg_color;
+}
+
 evview {
     background-color: @theme_bg_color;
 }