Skip to content

Commit ae7fa92

Browse files
committed
Print previewer: Multiple small fixes
- Remove MATE branding - Switch to symbolic icons - Give the toolbar a smaller icon size
1 parent 9c179d2 commit ae7fa92

4 files changed

Lines changed: 24 additions & 30 deletions

File tree

previewer/ev-previewer-window.c

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* ev-previewer-window.c:
1+
/* ev-previewer-window.c:
22
* this file is part of xreader, a generic document viewer
33
*
44
* Copyright (C) 2009 Carlos Garcia Campos <carlosgc@gnome.org>
@@ -246,7 +246,7 @@ ev_previewer_window_enumerate_finished (EvPreviewerWindow *window)
246246
GTK_PRINT_ERROR_GENERAL,
247247
_("The selected printer '%s' could not be found"),
248248
gtk_print_settings_get_printer (window->print_settings));
249-
249+
250250
ev_previewer_window_error_dialog_run (window, error);
251251
g_error_free (error);
252252
}
@@ -291,24 +291,24 @@ static const GtkActionEntry action_entries[] = {
291291
{ "FileCloseWindow", GTK_STOCK_CLOSE, NULL, "<control>W",
292292
NULL,
293293
G_CALLBACK (ev_previewer_window_close) },
294-
{ "GoPreviousPage", GTK_STOCK_GO_UP, N_("_Previous Page"), "<control>Page_Up",
294+
{ "GoPreviousPage", "go-previous-symbolic", N_("_Previous Page"), "<control>Page_Up",
295295
N_("Go to the previous page"),
296296
G_CALLBACK (ev_previewer_window_previous_page) },
297-
{ "GoNextPage", GTK_STOCK_GO_DOWN, N_("_Next Page"), "<control>Page_Down",
297+
{ "GoNextPage", "go-next-symbolic", N_("_Next Page"), "<control>Page_Down",
298298
N_("Go to the next page"),
299299
G_CALLBACK (ev_previewer_window_next_page) },
300-
{ "ViewZoomIn", GTK_STOCK_ZOOM_IN, NULL, "<control>plus",
300+
{ "ViewZoomIn", "zoom-in-symbolic", NULL, "<control>plus",
301301
N_("Enlarge the document"),
302302
G_CALLBACK (ev_previewer_window_zoom_in) },
303-
{ "ViewZoomOut", GTK_STOCK_ZOOM_OUT, NULL, "<control>minus",
303+
{ "ViewZoomOut", "zoom-out-symbolic", NULL, "<control>minus",
304304
N_("Shrink the document"),
305305
G_CALLBACK (ev_previewer_window_zoom_out) },
306-
{ "ViewZoomReset", GTK_STOCK_ZOOM_100, NULL, "<control>0",
306+
{ "ViewZoomReset", "zoom-original-symbolic", NULL, "<control>0",
307307
N_("Original size"),
308308
G_CALLBACK (ev_previewer_window_zoom_reset) },
309309
#if GTKUNIXPRINT_ENABLED
310310
/* translators: Print document currently shown in the Print Preview window */
311-
{ "PreviewPrint", GTK_STOCK_PRINT, N_("Print"), NULL,
311+
{ "PreviewPrint", "document-print-symbolic", N_("Print"), NULL,
312312
N_("Print this document"),
313313
G_CALLBACK (ev_previewer_window_print) }
314314
#endif
@@ -353,10 +353,10 @@ static const GtkActionEntry accel_entries[] = {
353353
};
354354

355355
static const GtkToggleActionEntry toggle_action_entries[] = {
356-
{ "ViewBestFit", EV_STOCK_ZOOM_PAGE, N_("_Best Fit"), NULL,
356+
{ "ViewBestFit", "zoom-fit-best-symbolic", N_("_Best Fit"), NULL,
357357
N_("Make the current document fill the window"),
358358
G_CALLBACK (ev_previewer_window_zoom_best_fit) },
359-
{ "ViewPageWidth", EV_STOCK_ZOOM_WIDTH, N_("Fit Page _Width"), NULL,
359+
{ "ViewPageWidth", "view-paged-symbolic", N_("Fit Page _Width"), NULL,
360360
N_("Make the current document fill the window width"),
361361
G_CALLBACK (ev_previewer_window_zoom_page_width) }
362362
};
@@ -592,6 +592,7 @@ ev_previewer_window_constructor (GType type,
592592
vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 0);
593593

594594
toolbar = gtk_ui_manager_get_widget (window->ui_manager, "/PreviewToolbar");
595+
gtk_toolbar_set_icon_size ( GTK_TOOLBAR (toolbar), GTK_ICON_SIZE_SMALL_TOOLBAR);
595596
gtk_box_pack_start (GTK_BOX (vbox), toolbar, FALSE, FALSE, 0);
596597
gtk_widget_show (toolbar);
597598

previewer/ev-previewer-window.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
/* ev-previewer-window.h:
2-
* this file is part of xreader, a mate document viewer
1+
/* ev-previewer-window.h:
32
*
43
* Copyright (C) 2009 Carlos Garcia Campos <carlosgc@gnome.org>
54
*

previewer/ev-previewer.c

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
/* ev-previewer.c:
2-
* this file is part of xreader, a mate document viewer
1+
/* ev-previewer.c:
32
*
43
* Copyright (C) 2009 Carlos Garcia Campos <carlosgc@gnome.org>
54
*
@@ -103,33 +102,30 @@ main (gint argc, gchar **argv)
103102
bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8");
104103
textdomain (GETTEXT_PACKAGE);
105104
#endif
106-
107-
context = g_option_context_new (_("MATE Document Previewer"));
105+
106+
context = g_option_context_new (_("Print Preview"));
108107
g_option_context_set_translation_domain (context, GETTEXT_PACKAGE);
109108
g_option_context_add_main_entries (context, goption_options, GETTEXT_PACKAGE);
110109

111110
g_option_context_add_group (context, gtk_get_option_group (TRUE));
112-
111+
113112
if (!g_option_context_parse (context, &argc, &argv, &error)) {
114113
g_warning ("Error parsing command line arguments: %s", error->message);
115114
g_error_free (error);
116115
g_option_context_free (context);
117-
118116
return 1;
119117
}
120118
g_option_context_free (context);
121119

122120
if (!filenames) {
123121
g_warning ("File argument is required");
124-
125122
return 1;
126123
}
127124

128125
filename = filenames[0];
129-
126+
130127
if (!g_file_test (filename, G_FILE_TEST_IS_REGULAR)) {
131128
g_warning ("Filename \"%s\" does not exist or is not a regular file", filename);
132-
133129
return 1;
134130
}
135131

@@ -138,21 +134,19 @@ main (gint argc, gchar **argv)
138134

139135
ev_stock_icons_init ();
140136

141-
g_set_application_name (_("MATE Document Previewer"));
137+
g_set_application_name (_("Print Preview"));
142138
gtk_window_set_default_icon_name ("xreader");
143139

144140
model = ev_document_model_new ();
145141
window = ev_previewer_window_new (model);
146142
ev_previewer_window_set_source_file (EV_PREVIEWER_WINDOW (window), filename);
147143
ev_previewer_window_set_print_settings (EV_PREVIEWER_WINDOW (window), print_settings);
148-
g_signal_connect (window, "delete-event",
149-
G_CALLBACK (gtk_main_quit), NULL);
150-
g_signal_connect (window, "destroy",
151-
G_CALLBACK (gtk_main_quit), NULL);
144+
g_signal_connect (window, "delete-event", G_CALLBACK (gtk_main_quit), NULL);
145+
g_signal_connect (window, "destroy", G_CALLBACK (gtk_main_quit), NULL);
152146
gtk_widget_show (window);
153147

154148
ev_previewer_load_document (filename, model);
155-
149+
156150
gtk_main ();
157151

158152
if (unlink_temp_file)
@@ -163,6 +157,6 @@ main (gint argc, gchar **argv)
163157
ev_shutdown ();
164158
ev_stock_icons_shutdown ();
165159
g_object_unref (model);
166-
160+
167161
return 0;
168162
}

previewer/xreader-previewer.1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ xreader\-previewer \- show print preview for a document
44
.SH SYNOPSIS
55
\fBxreader\-previewer\fR \fB[file]\fR
66
.SH DESCRIPTION
7-
xreader\-previewer is a MATE program to
7+
xreader\-previewer is a program to
88
show print preview dialog for files supported by xreader.
99
.SH OPTIONS
1010
xreader\-previewer obeys all normal GTK+
@@ -13,4 +13,4 @@ command line options.
1313
\fBxreader\fR(1),
1414
\fBgtk\-options\fR(7).
1515
.PP
16-
http://www.mate-desktop.org/
16+
https://www.github.com/linuxmint/xreader/

0 commit comments

Comments
 (0)