Skip to content

Commit 1270605

Browse files
committed
Merge tag 'pm-7.0-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
Pull power management fixes from Rafael Wysocki: "These fix a potential NULL pointer dereference in the energy model netlink interface and a potential double free in an error path in the common cpufreq governor management code: - Fix a NULL pointer dereference in the energy model netlink interface that may occur if a given perf domain ID is not recognized (Changwoo Min) - Avoid double free in the cpufreq_dbs_governor_init() error path when kobject_init_and_add() fails (Guangshuo Li)" * tag 'pm-7.0-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm: cpufreq: governor: fix double free in cpufreq_dbs_governor_init() error path PM: EM: Fix NULL pointer dereference when perf domain ID is not found
2 parents 576db0f + 744d572 commit 1270605

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

drivers/cpufreq/cpufreq_governor.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -468,13 +468,13 @@ int cpufreq_dbs_governor_init(struct cpufreq_policy *policy)
468468
/* Failure, so roll back. */
469469
pr_err("initialization failed (dbs_data kobject init error %d)\n", ret);
470470

471-
kobject_put(&dbs_data->attr_set.kobj);
472-
473471
policy->governor_data = NULL;
474472

475473
if (!have_governor_per_policy())
476474
gov->gdbs_data = NULL;
477-
gov->exit(dbs_data);
475+
476+
kobject_put(&dbs_data->attr_set.kobj);
477+
goto free_policy_dbs_info;
478478

479479
free_dbs_data:
480480
kfree(dbs_data);

kernel/power/em_netlink.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,8 @@ int dev_energymodel_nl_get_perf_domains_doit(struct sk_buff *skb,
109109

110110
id = nla_get_u32(info->attrs[DEV_ENERGYMODEL_A_PERF_DOMAIN_PERF_DOMAIN_ID]);
111111
pd = em_perf_domain_get_by_id(id);
112+
if (!pd)
113+
return -EINVAL;
112114

113115
__em_nl_get_pd_size(pd, &msg_sz);
114116
msg = genlmsg_new(msg_sz, GFP_KERNEL);

0 commit comments

Comments
 (0)