Skip to content

Commit c73134f

Browse files
Chen Nimaddy-kerneldev
authored andcommitted
powerpc/52xx/media5200: Consolidate chained IRQ handler install/remove
The driver currently sets the handler data and the chained handler in two separate steps. This creates a theoretical race window where an interrupt could fire after the handler is set but before the data is assigned, leading to a NULL pointer dereference. Replace the two calls with irq_set_chained_handler_and_data() to set both the handler and its data atomically under the irq_desc->lock. Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> Link: https://patch.msgid.link/20260119060450.889119-1-nichen@iscas.ac.cn
1 parent c7dafc4 commit c73134f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

arch/powerpc/platforms/52xx/media5200.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,8 @@ static void __init media5200_init_irq(void)
176176

177177
of_node_put(fpga_np);
178178

179-
irq_set_handler_data(cascade_virq, &media5200_irq);
180-
irq_set_chained_handler(cascade_virq, media5200_irq_cascade);
179+
irq_set_chained_handler_and_data(cascade_virq, media5200_irq_cascade,
180+
&media5200_irq);
181181

182182
return;
183183

0 commit comments

Comments
 (0)