Skip to content

Commit fe8343b

Browse files
rddunlapmaddy-kerneldev
authored andcommitted
powerpc/ps3: fix ps3.h kernel-doc warnings
Fix some kernel-doc warnings in ps3.h: - add @dev to struct ps3_dma_region - don't mark a function as "struct" - add Returns: description for one function - add a short description for ps3_system_bus_set_drvdata() - correct an enum @name - move intervening "struct ps3_system_bus_device;" from between kernel-doc for ps3_dma_region_init() and the function declaration to eliminate these warnings: Warning: arch/powerpc/include/asm/ps3.h:96 struct member 'dev' not described in 'ps3_dma_region' Warning: arch/powerpc/include/asm/ps3.h:118 struct ps3_system_bus_device; error: Cannot parse struct or union! Warning: arch/powerpc/include/asm/ps3.h:166 int ps3_mmio_region_init(struct ps3_system_bus_device *dev, struct ps3_mmio_region *r, unsigned long bus_addr, unsigned long len, enum ps3_mmio_page_size page_size); error: Cannot parse struct or union! Warning: arch/powerpc/include/asm/ps3.h:167 No description found for return value of 'ps3_mmio_region_init' Warning: arch/powerpc/include/asm/ps3.h:407 missing initial short description on line: * ps3_system_bus_set_drvdata - Warning: arch/powerpc/include/asm/ps3.h:473 Enum value 'PS3_LPM_TB_TYPE_INTERNAL' not described in enum 'ps3_lpm_tb_type' Warning: arch/powerpc/include/asm/ps3.h:473 Excess enum value '@PS3_LPM_RIGHTS_USE_TB' description in 'ps3_lpm_tb_type' This leaves struct members in several structs and function parameters in one function still undescribed. Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> Link: https://patch.msgid.link/20251129183636.1893634-1-rdunlap@infradead.org
1 parent 461d536 commit fe8343b

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

  • arch/powerpc/include/asm

arch/powerpc/include/asm/ps3.h

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ struct ps3_dma_region_ops;
6565

6666
/**
6767
* struct ps3_dma_region - A per device dma state variables structure
68+
* @dev: device structure
6869
* @did: The HV device id.
6970
* @page_size: The ioc pagesize.
7071
* @region_type: The HV region type.
@@ -108,15 +109,15 @@ struct ps3_dma_region_ops {
108109
dma_addr_t bus_addr,
109110
unsigned long len);
110111
};
112+
113+
struct ps3_system_bus_device;
114+
111115
/**
112116
* struct ps3_dma_region_init - Helper to initialize structure variables
113117
*
114118
* Helper to properly initialize variables prior to calling
115119
* ps3_system_bus_device_register.
116120
*/
117-
118-
struct ps3_system_bus_device;
119-
120121
int ps3_dma_region_init(struct ps3_system_bus_device *dev,
121122
struct ps3_dma_region *r, enum ps3_dma_page_size page_size,
122123
enum ps3_dma_region_type region_type, void *addr, unsigned long len);
@@ -156,10 +157,12 @@ struct ps3_mmio_region_ops {
156157
int (*free)(struct ps3_mmio_region *);
157158
};
158159
/**
159-
* struct ps3_mmio_region_init - Helper to initialize structure variables
160+
* ps3_mmio_region_init - Helper to initialize structure variables
160161
*
161162
* Helper to properly initialize variables prior to calling
162163
* ps3_system_bus_device_register.
164+
*
165+
* Returns: %0 on success, %-errno on error (or BUG())
163166
*/
164167

165168
int ps3_mmio_region_init(struct ps3_system_bus_device *dev,
@@ -405,7 +408,7 @@ static inline struct ps3_system_bus_driver *
405408
}
406409

407410
/**
408-
* ps3_system_bus_set_drvdata -
411+
* ps3_system_bus_set_drvdata - set driver's private data for this device
409412
* @dev: device structure
410413
* @data: Data to set
411414
*/
@@ -464,7 +467,7 @@ enum ps3_lpm_rights {
464467
* enum ps3_lpm_tb_type - Type of trace buffer lv1 should use.
465468
*
466469
* @PS3_LPM_TB_TYPE_NONE: Do not use a trace buffer.
467-
* @PS3_LPM_RIGHTS_USE_TB: Use the lv1 internal trace buffer. Must have
470+
* @PS3_LPM_TB_TYPE_INTERNAL: Use the lv1 internal trace buffer. Must have
468471
* rights @PS3_LPM_RIGHTS_USE_TB.
469472
*/
470473

0 commit comments

Comments
 (0)