fix(storage): ensure streams are buffered (#344)

Ensure files are not fully read into memory while streaming.

Author: cofin

.gitignore

@@ -61,3 +61,5 @@ specs/
 .playwright-mcp
 .geminiignore
 uv.toml
+.beads/
+.agent/

.pre-commit-config.yaml

@@ -17,7 +17,7 @@ repos:
       - id: mixed-line-ending
       - id: trailing-whitespace
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: "v0.14.13"
+    rev: "v0.14.14"
     hooks:
       - id: ruff
         args: ["--fix"]

pyproject.toml

@@ -24,7 +24,7 @@ maintainers = [{ name = "Litestar Developers", email = "hello@litestar.dev" }]
 name = "sqlspec"
 readme = "README.md"
 requires-python = ">=3.10, <4.0"
-version = "0.38.3"
+version = "0.38.4"
 
 [project.urls]
 Discord = "https://discord.gg/litestar"
@@ -240,7 +240,7 @@ opt_level = "3"   # Maximum optimization (0-3)
 allow_dirty = true
 commit = false
 commit_args = "--no-verify"
-current_version = "0.38.3"
+current_version = "0.38.4"
 ignore_missing_files = false
 ignore_missing_version = false
 message = "chore(release): bump to v{new_version}"

sqlspec/_typing.py

@@ -7,7 +7,7 @@
 from enum import Enum
 from typing import Any, ClassVar, Final, Literal, Protocol, cast, runtime_checkable
 
-from typing_extensions import TypeVar, dataclass_transform
+from typing_extensions import Self, TypeVar, dataclass_transform
 
 from sqlspec.utils.module_loader import dependency_flag, module_available
 
@@ -502,8 +502,8 @@ def set_status(self, status: Any, description: "str | None" = None) -> None:
         def end(self, end_time: "int | None" = None) -> None:
             return None
 
-        def __enter__(self) -> "Span":
-            return self  # type: ignore[return-value]
+        def __enter__(self) -> Self:
+            return self
 
         def __exit__(self, exc_type: object, exc_val: object, exc_tb: object) -> None:
             return None

sqlspec/adapters/adbc/driver.py

@@ -7,6 +7,8 @@
 import contextlib
 from typing import TYPE_CHECKING, Any, Literal, cast
 
+from typing_extensions import Self
+
 from sqlspec.adapters.adbc._typing import AdbcSessionContext
 from sqlspec.adapters.adbc.core import (
     collect_rows,
@@ -83,7 +85,7 @@ class AdbcExceptionHandler:
     def __init__(self) -> None:
         self.pending_exception: Exception | None = None
 
-    def __enter__(self) -> "AdbcExceptionHandler":
+    def __enter__(self) -> Self:
         return self
 
     def __exit__(self, exc_type: Any, exc_val: Any, exc_tb: Any) -> bool:

sqlspec/adapters/aiosqlite/driver.py

@@ -30,6 +30,8 @@
     from sqlspec.driver import ExecutionResult
     from sqlspec.storage import StorageBridgeJob, StorageDestination, StorageFormat, StorageTelemetry
 
+from typing_extensions import Self
+
 from sqlspec.adapters.aiosqlite._typing import AiosqliteSessionContext
 
 __all__ = ("AiosqliteCursor", "AiosqliteDriver", "AiosqliteExceptionHandler", "AiosqliteSessionContext")
@@ -81,7 +83,7 @@ class AiosqliteExceptionHandler:
     def __init__(self) -> None:
         self.pending_exception: Exception | None = None
 
-    async def __aenter__(self) -> "AiosqliteExceptionHandler":
+    async def __aenter__(self) -> Self:
         return self
 
     async def __aexit__(self, exc_type: Any, exc_val: Any, exc_tb: Any) -> bool:

sqlspec/adapters/asyncmy/driver.py

@@ -39,6 +39,8 @@
     from sqlspec.driver import ExecutionResult
     from sqlspec.storage import StorageBridgeJob, StorageDestination, StorageFormat, StorageTelemetry
 
+from typing_extensions import Self
+
 from sqlspec.adapters.asyncmy._typing import AsyncmySessionContext
 
 __all__ = ("AsyncmyCursor", "AsyncmyDriver", "AsyncmyExceptionHandler", "AsyncmySessionContext")
@@ -88,7 +90,7 @@ class AsyncmyExceptionHandler:
     def __init__(self) -> None:
         self.pending_exception: Exception | None = None
 
-    async def __aenter__(self) -> "AsyncmyExceptionHandler":
+    async def __aenter__(self) -> Self:
         return self
 
     async def __aexit__(self, exc_type: Any, exc_val: Any, exc_tb: Any) -> bool:

sqlspec/adapters/asyncpg/driver.py

@@ -40,6 +40,8 @@
     from sqlspec.driver import ExecutionResult
     from sqlspec.storage import StorageBridgeJob, StorageDestination, StorageFormat, StorageTelemetry
 
+from typing_extensions import Self
+
 from sqlspec.adapters.asyncpg._typing import AsyncpgSessionContext
 
 __all__ = ("AsyncpgCursor", "AsyncpgDriver", "AsyncpgExceptionHandler", "AsyncpgSessionContext")
@@ -77,7 +79,7 @@ class AsyncpgExceptionHandler:
     def __init__(self) -> None:
         self.pending_exception: Exception | None = None
 
-    async def __aenter__(self) -> "AsyncpgExceptionHandler":
+    async def __aenter__(self) -> Self:
         return self
 
     async def __aexit__(self, exc_type: Any, exc_val: Any, exc_tb: Any) -> bool:

sqlspec/adapters/bigquery/driver.py

@@ -106,7 +106,7 @@ class BigQueryExceptionHandler:
     def __init__(self) -> None:
         self.pending_exception: Exception | None = None
 
-    def __enter__(self) -> "BigQueryExceptionHandler":
+    def __enter__(self) -> "Self":
         return self
 
     def __exit__(self, exc_type: Any, exc_val: Any, exc_tb: Any) -> bool:

sqlspec/adapters/cockroach_asyncpg/driver.py

@@ -5,6 +5,7 @@
 from typing import TYPE_CHECKING, Any, cast
 
 import asyncpg
+from typing_extensions import Self
 
 from sqlspec.adapters.asyncpg.core import create_mapped_exception, driver_profile
 from sqlspec.adapters.asyncpg.driver import AsyncpgDriver
@@ -40,7 +41,7 @@ class CockroachAsyncpgExceptionHandler:
     def __init__(self) -> None:
         self.pending_exception: Exception | None = None
 
-    async def __aenter__(self) -> "CockroachAsyncpgExceptionHandler":
+    async def __aenter__(self) -> Self:
         return self
 
     async def __aexit__(self, exc_type: Any, exc_val: Any, exc_tb: Any) -> bool: