Skip to content

Commit 13fabd0

Browse files
- changed the type from string to integer for the setter und getter o… (#211)
* - changed the type from string to integer for the setter und getter of the voiceBridge * - codestyle fix in the URLBuilder class --------- Co-authored-by: Felix Jacobi <felix@jacobi-hamburg.net>
1 parent 672f881 commit 13fabd0

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/Parameters/CreateMeetingParameters.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@
3535
* @method $this setWelcome(string $welcome)
3636
* @method string getDialNumber()
3737
* @method $this setDialNumber(string $dialNumber)
38-
* @method string getVoiceBridge()
39-
* @method $this setVoiceBridge(string $voiceBridge)
38+
* @method int getVoiceBridge()
39+
* @method $this setVoiceBridge(int $voiceBridge)
4040
* @method string getWebVoice()
4141
* @method $this setWebVoice(string $webVoice)
4242
* @method int getMaxParticipants()

src/Util/UrlBuilder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ final class UrlBuilder
3535
public function __construct(
3636
private readonly string $securitySalt,
3737
private readonly string $bbbServerBaseUrl,
38-
private readonly HashingAlgorithm $hashingAlgorithm
38+
private readonly HashingAlgorithm $hashingAlgorithm,
3939
) {
4040
}
4141

tests/unit/BigBlueButtonTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ public function testGetMeetings(): void
357357
$this->assertEquals('12345', $response->getMeetings()[0]->getInternalMeetingId());
358358
$this->assertEquals(1531241258036, $response->getMeetings()[0]->getCreationTime());
359359
$this->assertEquals('Tue Jul 10 16:47:38 UTC 2018', $response->getMeetings()[0]->getCreationDate());
360-
$this->assertEquals('70066', $response->getMeetings()[0]->getVoiceBridge());
360+
$this->assertEquals(70066, $response->getMeetings()[0]->getVoiceBridge());
361361
$this->assertEquals('613-555-1234', $response->getMeetings()[0]->getDialNumber());
362362
$this->assertFalse($response->getMeetings()[0]->isRunning());
363363
$this->assertEquals(0, $response->getMeetings()[0]->getDuration());

0 commit comments

Comments
 (0)