Skip to content

Commit 1d2f423

Browse files
Add new create meeting param allowPromoteGuestToModerator (#203)
* Add allowPromoteGuestToModerator * Remove code duplication --------- Co-authored-by: Felix Jacobi <felix@jacobi-hamburg.net>
1 parent 7761b10 commit 1d2f423

3 files changed

Lines changed: 10 additions & 1 deletion

File tree

src/Parameters/CreateMeetingParameters.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,8 @@
120120
* @method $this setAllowModsToEjectCameras(bool $isAllowModsToEjectCameras)
121121
* @method bool|null isAllowRequestsWithoutSession()
122122
* @method $this setAllowRequestsWithoutSession(bool $isAllowRequestsWithoutSession)
123+
* @method bool|null isAllowPromoteGuestToModerator()
124+
* @method $this setAllowPromoteGuestToModerator(bool $isAllowPromoteGuestToModerator)
123125
* @method int getUserCameraCap()
124126
* @method $this setUserCameraCap(int $cap)
125127
* @method int getMeetingCameraCap()
@@ -386,6 +388,11 @@ class CreateMeetingParameters extends MetaParameters
386388
*/
387389
protected $allowRequestsWithoutSession;
388390

391+
/**
392+
* @var bool
393+
*/
394+
protected $allowPromoteGuestToModerator;
395+
389396
/**
390397
* @var bool
391398
*/

tests/TestCase.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ protected function generateCreateParams()
9999
'lockSettingsLockOnJoinConfigurable' => $this->faker->boolean(50),
100100
'allowModsToUnmuteUsers' => $this->faker->boolean(50),
101101
'allowModsToEjectCameras' => $this->faker->boolean(50),
102+
'allowPromoteGuestToModerator' => $this->faker->boolean(50),
102103
'disabledFeatures' => $this->faker->randomElements(Feature::getValues(), 3),
103104
'disabledFeaturesExclude' => $this->faker->randomElements(Feature::getValues(), 2),
104105
'meta_presenter' => $this->faker->name,
@@ -209,6 +210,7 @@ protected function getCreateMock($params)
209210
->setBreakoutRoomsPrivateChatEnabled($params['breakoutRoomsPrivateChatEnabled'])
210211
->setBreakoutRoomsRecord($params['breakoutRoomsRecord'])
211212
->setAllowRequestsWithoutSession($params['allowRequestsWithoutSession'])
213+
->setAllowPromoteGuestToModerator($params['allowPromoteGuestToModerator'])
212214
->setVirtualBackgroundsDisabled($params['virtualBackgroundsDisabled'])
213215
->setUserCameraCap($params['userCameraCap'])
214216
->setDisabledFeatures($params['disabledFeatures'])

tests/unit/Parameters/CreateMeetingParametersTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ public function testCreateMeetingParameters()
6363
$this->assertEquals($params['lockSettingsLockOnJoinConfigurable'], $createMeetingParams->isLockSettingsLockOnJoinConfigurable());
6464
$this->assertEquals($params['allowModsToUnmuteUsers'], $createMeetingParams->isAllowModsToUnmuteUsers());
6565
$this->assertEquals($params['allowModsToEjectCameras'], $createMeetingParams->isAllowModsToEjectCameras());
66+
$this->assertEquals($params['allowPromoteGuestToModerator'], $createMeetingParams->isAllowPromoteGuestToModerator());
6667
$this->assertEquals($params['guestPolicy'], $createMeetingParams->getGuestPolicy());
6768
$this->assertEquals($params['endWhenNoModerator'], $createMeetingParams->isEndWhenNoModerator());
6869
$this->assertEquals($params['endWhenNoModeratorDelayInMinutes'], $createMeetingParams->getEndWhenNoModeratorDelayInMinutes());
@@ -84,7 +85,6 @@ public function testCreateMeetingParameters()
8485
$this->assertEquals($params['meetingLayout'], $createMeetingParams->getMeetingLayout());
8586
$this->assertEquals($params['learningDashboardEnabled'], $createMeetingParams->isLearningDashboardEnabled());
8687
$this->assertEquals($params['learningDashboardCleanupDelayInMinutes'], $createMeetingParams->getLearningDashboardCleanupDelayInMinutes());
87-
$this->assertEquals($params['allowModsToEjectCameras'], $createMeetingParams->isAllowModsToEjectCameras());
8888
$this->assertEquals($params['breakoutRoomsEnabled'], $createMeetingParams->isBreakoutRoomsEnabled());
8989
$this->assertEquals($params['breakoutRoomsPrivateChatEnabled'], $createMeetingParams->isBreakoutRoomsPrivateChatEnabled());
9090
$this->assertEquals($params['breakoutRoomsRecord'], $createMeetingParams->isBreakoutRoomsRecord());

0 commit comments

Comments
 (0)