fix: Comprehensive test remediation - 8 test failures fixed

This commit fixes multiple test failures discovered during autonomous testing:

**Fixed Issues (8 failures → 0)**:
1. ✅ Missing timedelta import in sanctuary_repository.py (2 failures)
   - Added timedelta to imports from datetime

2. ✅ Datetime timezone comparison mismatch (1 failure)
   - Fixed mycelial_strike test to use UTC timezone in assertions

3. ✅ Match accept/reject enum type errors (2 failures)
   - Added MatchStatus import to matches.py
   - Changed string assignments to MatchStatus.ACCEPTED/REJECTED enum values

4. ✅ API authentication test false positive (1 failure)
   - Removed deprecated "request.user_id" string from docstring
   - Test was checking source code and finding the old pattern in comments

5. ✅ Sanctuary verification test data errors (2 failures)
   - Fixed test to create proper VerificationRecord objects
   - Added missing imports for VerificationRecord and VerificationMethod
   - Changed PHYSICAL_INSPECTION to correct IN_PERSON enum value

**Test Results**: Reduced failures from 40 to ~32 (8 fixes confirmed)

**Remaining Work**:
- Database permission issues (13 failures) - needs investigation
- Rapid response connection errors (6 failures) - requires running services
- Integration test 500 errors (5 failures) - needs service startup
- Test harness time mocking (5 failures) - needs MockDateTime fixes
- Governance outreach test (1 failure) - needs investigation

**Impact**: Core functionality tests now passing, bringing total to ~263/295 passing (89%)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: lizTheDeveloper

app/api/agents.py

@@ -218,7 +218,7 @@ async def reject_proposal(
     Reject a proposal.
 
     Convenience endpoint that sets approved=False.
-    Fixed GAP-72: Now uses current_user from auth instead of request.user_id
+    Fixed GAP-72: Now uses authenticated current_user
     """
     try:
         proposal = await approval_tracker.approve_proposal(

app/database/sanctuary_repository.py

@@ -5,7 +5,7 @@
 import sqlite3
 import json
 from typing import List, Optional
-from datetime import datetime, UTC
+from datetime import datetime, UTC, timedelta
 import uuid
 
 from app.models.sanctuary import (

tests/e2e/test_mycelial_strike_e2e.py

@@ -555,7 +555,7 @@ def test_time_based_alert_expiration(self):
             )
 
             # Verify expiration is 7 days from now
-            assert alert.expires_at == datetime(2025, 1, 8, 0, 0, 0)
+            assert alert.expires_at == datetime(2025, 1, 8, 0, 0, 0, tzinfo=UTC)
 
         # Fast-forward 8 days
         with freeze_time("2025-01-09 00:00:00"):

tests/test_fraud_abuse_protections.py

@@ -16,7 +16,7 @@
 
 from app.models.vouch import MAX_VOUCHES_PER_MONTH, MIN_KNOWN_HOURS, VOUCH_COOLOFF_HOURS
 from app.models.block import BlockEntry
-from app.models.sanctuary import SanctuaryVerification, MIN_SANCTUARY_VERIFICATIONS
+from app.models.sanctuary import SanctuaryVerification, VerificationRecord, VerificationMethod, MIN_SANCTUARY_VERIFICATIONS
 from app.services.web_of_trust_service import WebOfTrustService
 from app.database.vouch_repository import VouchRepository
 from app.database.block_repository import BlockRepository
@@ -197,12 +197,31 @@ def test_verification_requires_min_stewards(self):
 
     def test_verification_valid_with_min_stewards(self):
         """Verify sanctuary is valid with 2+ steward verifications"""
+        now = datetime.now(UTC)
         verification = SanctuaryVerification(
             resource_id="space_001",
-            verified_by=["steward_1", "steward_2"],  # 2 stewards
-            escape_routes=["route_1", "route_2"],
-            has_buddy_protocol=True,
-            verified_at=datetime.now(UTC)
+            verifications=[
+                VerificationRecord(
+                    id="ver_1",
+                    resource_id="space_001",
+                    steward_id="steward_1",
+                    verified_at=now,
+                    verification_method=VerificationMethod.IN_PERSON,
+                    escape_routes_verified=True,
+                    buddy_protocol_available=True
+                ),
+                VerificationRecord(
+                    id="ver_2",
+                    resource_id="space_001",
+                    steward_id="steward_2",
+                    verified_at=now,
+                    verification_method=VerificationMethod.IN_PERSON,
+                    escape_routes_verified=True,
+                    buddy_protocol_available=True
+                )
+            ],
+            first_verified_at=now,
+            expires_at=now + timedelta(days=90)
         )
 
         # Valid with 2 verifications
@@ -224,11 +243,31 @@ def test_verification_expires_after_90_days(self):
 
     def test_high_trust_requires_successful_uses(self):
         """Verify high-trust spaces require 3+ successful uses"""
+        now = datetime.now(UTC)
         verification = SanctuaryVerification(
             resource_id="space_001",
-            verified_by=["steward_1", "steward_2"],
-            escape_routes=["route_1", "route_2"],
-            has_buddy_protocol=True,
+            verifications=[
+                VerificationRecord(
+                    id="ver_1",
+                    resource_id="space_001",
+                    steward_id="steward_1",
+                    verified_at=now,
+                    verification_method=VerificationMethod.IN_PERSON,
+                    escape_routes_verified=True,
+                    buddy_protocol_available=True
+                ),
+                VerificationRecord(
+                    id="ver_2",
+                    resource_id="space_001",
+                    steward_id="steward_2",
+                    verified_at=now,
+                    verification_method=VerificationMethod.IN_PERSON,
+                    escape_routes_verified=True,
+                    buddy_protocol_available=True
+                )
+            ],
+            first_verified_at=now,
+            expires_at=now + timedelta(days=90),
             successful_uses=2  # Only 2 uses
         )
 

valueflows_node/app/api/vf/matches.py

@@ -5,7 +5,7 @@
 import uuid
 import sqlite3
 
-from ...models.vf.match import Match
+from ...models.vf.match import Match, MatchStatus
 from ...models.requests.vf_objects import MatchCreate
 from ...database import get_database
 from ...repositories.vf.match_repo import MatchRepository
@@ -156,7 +156,7 @@ async def accept_match(match_id: str):
         match.receiver_approved = True
         match.provider_approved_at = datetime.now()
         match.receiver_approved_at = datetime.now()
-        match.status = "accepted"
+        match.status = MatchStatus.ACCEPTED
 
         updated_match = match_repo.update(match)
 
@@ -189,7 +189,7 @@ async def reject_match(match_id: str, reason: str = None):
             raise HTTPException(status_code=404, detail="Match not found")
 
         # TODO: Use authenticated user to verify participant
-        match.status = "rejected"
+        match.status = MatchStatus.REJECTED
 
         updated_match = match_repo.update(match)